[derrickaw]

1. add kafka to spanner blueprint, IT etc
2. update kafka options

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.99%. Comparing base (ebecaab) to head (a393519).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #4365   +/-   ##
=========================================
  Coverage     37.99%   37.99%           
  Complexity      517      517           
=========================================
  Files           195      195           
  Lines         11879    11879           
  Branches       1212     1212           
=========================================
  Hits           4514     4514           
  Misses         6994     6994           
  Partials        371      371           

Components	Coverage Δ
spanner-templates	∅ <ø> (∅)
spanner-import-export	∅ <ø> (∅)
spanner-live-forward-migration	∅ <ø> (∅)
spanner-live-reverse-replication	∅ <ø> (∅)
spanner-bulk-migration	∅ <ø> (∅)
gcs-spanner-dv	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the Dataflow YAML template library by adding support for streaming data from Apache Kafka to Cloud Spanner. The changes include the necessary template definitions, configuration options, and integration tests. Additionally, the PR performs a cleanup of existing Kafka-based templates to maintain parameter consistency and introduces a new configuration field for read time management.

Highlights

• New Template Added: Introduced the Kafka to Spanner YAML template, enabling streaming data ingestion from Apache Kafka to Cloud Spanner.
• Configuration Updates: Refactored Kafka template parameters by removing redundant fields and adding the 'maxReadTimeSeconds' option across Kafka-to-BigQuery and Kafka-to-Iceberg templates.
• Integration Testing: Added a comprehensive integration test suite for the new Kafka to Spanner template to ensure pipeline reliability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new Kafka to Spanner (YAML) template, including its Java interface, options, pipeline definition, documentation, and integration tests. Additionally, it refactors the Kafka options across other YAML templates (BigQuery and Iceberg) by removing several duplicate-related parameters and adding maxReadTimeSeconds. The review feedback identifies critical syntax errors in the newly added KafkaToSpanner.yaml file, specifically pointing out that the filesToCopy and requirements properties are incorrectly formatted and should be defined as standard YAML sequences to prevent parsing and execution failures.

[damccorm]

There's heavy overlap with #4363 (and comments that apply across both) so I'm going to let that one get to completion and then we can follow up with review here.

[damccorm]

#4363 is in, so once this is updated to pull in those changes/resolve conflicts I can review (guessing it should be quick).

[damccorm]

Thanks - feedback is minor, feel free to merge after it is addressed