Skip to content

Stop picking a constructor by declaration order in a serialization test #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksandar-apostolov wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Stop picking a constructor by declaration order in a serialization test #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...etstream/android/core/internal/serialization/StreamCompositeEventSerializationImplTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,18 @@ class StreamCompositeEventSerializationImplTest {

@Test
fun `serialize - neither core nor product returns failure`() {
// Create an instance with both nulls via reflection (private ctor).
val k = StreamCompositeSerializationEvent::class.java.declaredConstructors.first()
k.isAccessible = true
// `external` takes a nullable T, so a null product reaches the both-null state without
// reflection. The cast is safe — the type parameter is erased and neither field is read
// as a String on this path.
@Suppress("UNCHECKED_CAST")
val emptyEvt = k.newInstance(null, null, null) as StreamCompositeSerializationEvent<String>
val emptyEvt =
StreamCompositeSerializationEvent.external<String?>(null)
as StreamCompositeSerializationEvent<String>

// Pin the precondition — if construction stops producing both-null, fail here rather
// than misattributing it to the serializer.
assertNull(emptyEvt.core)
assertNull(emptyEvt.product)

val sut = newSut()
val res = sut.serialize(emptyEvt)
Expand Down
Loading