Stop picking a constructor by declaration order in a serialization test - #81
Open
aleksandar-apostolov wants to merge 1 commit into
Open
aleksandar-apostolov wants to merge 1 commit into
aleksandar-apostolov wants to merge 1 commit into
Conversation
getDeclaredConstructors() ordering is unspecified, so .first() started returning the 2-arg private constructor instead of the 3-arg access bridge and newInstance(null, null, null) threw. Reach the both-null state through the external() factory instead and pin the precondition.
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
aleksandar-apostolov
marked this pull request as ready for review
September 16, 2026 08:07
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andremion
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes AND-1531 —
StreamCompositeEventSerializationImplTest.serialize - neither core nor product returns failurebuilds its fixture by indexing intogetDeclaredConstructors(), whose ordering the JVM spec leaves unspecified.StreamCompositeSerializationEventcompiles to three constructors — the 2-argprivate (StreamClientWsEvent, T), the 4-arg defaults synthetic, and the 3-arg public access bridge. The test callsnewInstance(null, null, null), so it only works while.first()happens to return the bridge.It is green on CI today and red on at least one developer machine, where the 2-arg constructor is emitted first and
newInstancethrowsIllegalArgumentException: wrong number of arguments. Nothing is blocked — this is a latent trap that fires whenever the compiler's emission order shifts.Implementation
external()takes a nullableT, soexternal<String?>(null)reaches the both-null state through the public factory; the unchecked cast covers the erased type parameter, and neither field is read as aStringon this path.assertNulloncoreandproductbefore exercising the serializer. This test's failure mode was its construction step silently ceasing to do what it claimed, and the behaviour assertions alone would have pointed at the serializer rather than the fixture.No production code touched.
Testing
./gradlew :stream-android-core:testDebugUnitTest— 757 tests, 0 failures, on a machine where this test was previously the one red.