Repository navigation
fix(operator): verify module signatures with cosign v3 - #684
Conversation
cosign/v2 v2.6.5 carries GO-2026-4529 and pulls x/crypto/openpgp (GO-2026-5932) into internal/verify; neither has a v2 fix. Move to github.com/sigstore/cosign/v3 v3.1.2, the same release the publish workflows sign with. The pkg/cosign, pkg/oci/remote and pkg/signature APIs the verifier uses are unchanged in v3, so only the import paths move. Spec 013 G1 (T021). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR changes only Generated by Claude Code |
CI Report - e043774run 38285390059 - attempt 2 0 failed - 25 passed - 1 skipped - unknown elapsed Coverage
Changed
Slowest jobsno job duration data available e2e buckets run
|
…inistic Two T184 Share polling tests mixed shouldAdvanceTime fake timers with a synchronous advanceTimersByTime and waitFor, so they timed out on busy runners (#677, #678). They now use pure fake timers advanced with advanceTimersByTimeAsync inside act, like the newer T184 test in the same file. The CaptureWidget download-button test asserted the button was enabled before the capabilities query had resolved (#672, #684); it now waits for that. Assertions are unchanged. valgul chose "Fix in #677". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Brings in the cosign v3 migration (#684) so govulncheck can re-check the operator module. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Before: the operator verified module signatures with
github.com/sigstore/cosign/v2v2.6.5. govulncheck (spec 013 G1, #673) reports two advisories reached fromoperator/internal/verify/verify.gothat have no v2 fix: GO-2026-4529 in cosign/v2 itself, and GO-2026-5932 ingolang.org/x/crypto/openpgp, which cosign pulls in.After: the operator uses
github.com/sigstore/cosign/v3v3.1.2, the same cosign release that publish-edge and release already sign with.The
pkg/cosign,pkg/oci/remoteandpkg/signatureAPIs the verifier calls are unchanged in v3, so only the import paths andgo.mod/go.summove. Verification behaviour is unchanged; the existing verify unit tests and the module-verification e2e paths cover it.How:
go get github.com/sigstore/cosign/v3@v3.1.2, rewrite the three imports,go mod tidy. Local check:go build ./...andgo vet ./internal/verify/compile clean. x/crypto/openpgp is still linked through rekor's PGP type; whether govulncheck still finds it reachable shows on #673 once this merges and master is merged into it (this PR's CI has no govulncheck job yet).Spec 013 T021. #673 (the govulncheck gate) merges after this.
🤖 Generated with Claude Code
Generated by Claude Code
Generated by Claude Code
Summary by CodeRabbit