Skip to content

ci: codegen drift gate (spec 013 G5) - #672

Merged
ValgulNecron merged 4 commits into
masterfrom
claude/013-codegen-drift
Oct 12, 2026
Merged

ci: codegen drift gate (spec 013 G5)#672
ValgulNecron merged 4 commits into
masterfrom
claude/013-codegen-drift

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Depends on #671 (its setup commit is included here until that merges).

Before: nothing in CI regenerated deepcopy, CRD/RBAC manifests or go.mod/go.sum, so a CRD types edit committed without make generate manifests or make tidy could merge.

After: a new codegen drift job runs make generate manifests, make tidy and git diff --exit-code. It runs when CRD types, generated configs, chart CRDs, go.mod/go.sum or the Makefile change, and on every master push. It is registered in the ci report.

How: hack/check-codegen-drift_test.sh proves the gate in a throwaway worktree. It commits a doc-comment and json-tag edit to GameServerSpec.Suspend without regenerating, requires regeneration to succeed and the diff to be non-empty, then drops the commit and requires a clean diff. T012–T013; T014 (commit any drift the first run reports, flip G-05) follows from this PR's first CI run.

🤖 Generated with Claude Code

Generated by Claude Code

@claude
ci: codegen drift gate (spec 013 G5)
50222b1 
New "codegen drift" job runs make generate manifests, make tidy and
git diff --exit-code when CRD types, go.mod/go.sum, generated configs or
chart CRDs change (and on every master push). hack/check-codegen-drift_test.sh
proves it goes red on a types edit committed without regenerating, and
green on a clean checkout. Registered in the ci report. T012-T013.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: GameplanePanel/Gameplane/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0599bb61-f6d6-4a3d-87cf-565527f50167
📥 Commits

Reviewing files that changed from the base of the PR and between 7124f63 and b96b9a6.

⛔ Files ignored due to path filters (1)
  • go.work.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • .github/workflows/ci.yaml
  • hack/check-codegen-drift_test.sh
  • specs/013-expand-test-coverage/coverage-gaps.md
  • specs/013-expand-test-coverage/tasks.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ValgulNecron ValgulNecron added type: ci CI, workflows, or build tooling area: operator controller-runtime operator and CRDs labels Oct 12, 2026 — with Claude
@ValgulNecron ValgulNecron self-assigned this Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Report - b96b9a6

run 38287109592 - attempt 2

0 failed - 27 passed - 0 skipped - 140m25s elapsed

Coverage

Module Measured Gate Margin
web L95.48 S93.97 B88.66 F91.78 L92 S92 B82 F76 +1.97

Changed

Area Files +/-
hack/ 1 +90/-0
.github/ 1 +30/-1
specs/ 2 +7/-6
(root) 1 +1/-0

Slowest jobs

Job Duration
e2e telemetry / amd64 (kind) 23m21s
e2e telemetry / arm64 (kind) 22m47s
e2e capture overhead (kind) 14m12s
build e2e images 13m1s
e2e game bot / TestGameServer_GarrysModBot_Query (kind) 9m43s

e2e buckets run

api-agent, api-auth, api-mods, api-rbac, api-roles, bot-fast, multicluster, operator, ratelimit, telemetry, upgrade

claude added 3 commits October 12, 2026 17:30
@claude
Merge remote-tracking branch 'origin/master' into claude/013-codegen-…
6ab12a7 
…drift

Signed-off-by: Claude <noreply@anthropic.com>
@claude
docs(specs): flip G-05 after the first green codegen drift run (T014)
3d65fd4 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@claude
chore(go): regenerate go.work.sum after codegen (spec 013 G5 drift)
b96b9a6 
The codegen drift gate found go.work.sum missing the
prometheus/client_golang v1.23.2 go.mod hash that make generate
manifests records after master's latest dependency changes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron Claude

ValgulNecron commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

web failed on b96b9a6 in CaptureWidget.test.tsx › "enables download button only for Completed captures". It's the same failure as on #684. This PR touches only CI wiring, a hack script and go.work.sum.

Cause: the download button's canDownload waits on the capabilities query (CaptureWidget.tsx:141). The test asserts not.toBeDisabled() as soon as the capture list renders, so when the list query resolves before the capabilities query, the button is still disabled. The race is in the test, not in this change. Changing the test needs the maintainer's sign-off, which I've asked for, so I'm re-running the failed job once the run finishes.

Generated by Claude Code

ValgulNecron pushed a commit that referenced this pull request Oct 12, 2026
@claude
test(web): make Share polling and CaptureWidget download tests determ…
a8ffe53 
…inistic

Two T184 Share polling tests mixed shouldAdvanceTime fake timers with
a synchronous advanceTimersByTime and waitFor, so they timed out on
busy runners (#677, #678). They now use pure fake timers advanced with
advanceTimersByTimeAsync inside act, like the newer T184 test in the
same file. The CaptureWidget download-button test asserted the button
was enabled before the capabilities query had resolved (#672, #684);
it now waits for that. Assertions are unchanged. valgul chose
"Fix in #677".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron
ValgulNecron marked this pull request as ready for review October 12, 2026 21:10
@ValgulNecron
ValgulNecron merged commit e40ca90 into master Oct 12, 2026
169 of 171 checks passed
ValgulNecron pushed a commit that referenced this pull request Oct 12, 2026
@claude
docs(specs): recount the 013 coverage-gaps summary
b7b375d 
#672 and #674 each raised the closed count from 2 to 3 on their own
branches, so after both merged the summary said 3 closed while the
table holds 4, which make check-coverage-gaps rejects.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
ValgulNecron pushed a commit that referenced this pull request Oct 12, 2026
@claude
docs(specs): recount the 013 coverage-gaps summary
590bb1b 
#672 and #674 each raised the closed count from 2 to 3 on their own
branches, so after both merged the summary said 3 closed while the
table holds 4, which make check-coverage-gaps rejects.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron mentioned this pull request Oct 12, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ValgulNecron ValgulNecron

Labels

area: operator controller-runtime operator and CRDs type: ci CI, workflows, or build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValgulNecron @claude