pi0.5: raise prompt token cap 128/180 -> 200 to match pi0.5 base training#478
Open
ElmoPA wants to merge 1 commit into
Open
pi0.5: raise prompt token cap 128/180 -> 200 to match pi0.5 base training#478ElmoPA wants to merge 1 commit into
ElmoPA wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…ning The PI prompt tokenizer was capping text at tokenizer_max_length=128 (a legacy default carried over from the old build_tokenized_collate) while the model was instantiated with max_token_len=180 -- both below pi0.5's actual training length. pi0.5 base was trained/released with max_token_len=200 (openpi Pi0Config pi05 default; gs://openpi-assets/checkpoints/pi05_base). Raising both knobs to 200 matches the pretrained checkpoint and is in-distribution (Gemma uses RoPE, so there is no positional-table limit). This roughly doubles the usable annotation budget once the proprio + control-mode blocks are spliced into the prompt, and removes the truncation footgun where an over-long prompt (truncation=True, right side) silently clipped the trailing State / "Action:" anchor. - max_token_len: 180 -> 200 - tokenizer_max_length: 128 -> 200 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1d1b74c to
5bbcc39
Compare
Claude Code ReviewSummaryBumps pi0.5 prompt token cap from 128/180 → 200 to align with the pi0.5 base checkpoint's pretraining Key concerns
Suggestions
VerdictApprove — small, well-justified config alignment with the upstream checkpoint. Just verify no cached tokenizations and no stray 180/128 constants before merging. Reviewed by Claude · Review workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The PI prompt tokenizer was capping text at tokenizer_max_length=128 (a
legacy default carried over from the old build_tokenized_collate) while
the model was instantiated with max_token_len=180 -- both below pi0.5's
actual training length.
pi0.5 base was trained/released with max_token_len=200 (openpi Pi0Config
pi05 default; gs://openpi-assets/checkpoints/pi05_base). Raising both
knobs to 200 matches the pretrained checkpoint and is in-distribution
(Gemma uses RoPE, so there is no positional-table limit). This roughly
doubles the usable annotation budget once the proprio + control-mode
blocks are spliced into the prompt, and removes the truncation footgun
where an over-long prompt (truncation=True, right side) silently clipped
the trailing State / "Action:" anchor.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com