Repository navigation
Wait for the broker schema agent to launch in startBrokerAgent - #415
Merged
Merged
Conversation
startBrokerAgent returned before the agent was launched, so a suspend arriving in that window found nothing to stop and the agent kept running with no record of it. The platform now needs this call to only resolve once the agent is actually up.
This was referenced Oct 14, 2026
cstns
marked this pull request as ready for review
October 14, 2026 10:17
hardillb
approved these changes
Oct 14, 2026
hardillb
reviewed
Oct 14, 2026
hardillb
left a comment
hardillb
left a comment
Contributor
There was a problem hiding this comment.
Just because we await the creation of the k8s objects doesn't mean they are running yet, they may be blocked waiting on k8s resources (e.g. a new node)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #414
Merge order: this, FlowFuse/driver-localfs#363 and FlowFuse/driver-docker#254 go first and get released, then FlowFuse/flowfuse#8917 together with bumping the driver versions.
startBrokerAgentkicked offcreateMQTTTopicAgentwithout awaiting it, so it resolved before the deployment and service were created. A suspend landing in that gap fails on the service that doesn't exist yet (logged, and the pod/deployment deletes after it are skipped), and the deployment gets created afterwards with no record of it on the platform (FlowFuse/flowfuse#8619). It now awaits the create.createMQTTTopicAgentalready catches and logs its own errors, so this doesn't change what the caller sees on failure.Not touched here, but might be worth a separate look: since a missing service skips the deployment delete, a deployment whose service is gone for any other reason won't get cleaned up by
stopBrokerAgenteither.Same change as FlowFuse/driver-localfs#363, which I raced against the local app (0 orphans out of 24 together with FlowFuse/flowfuse#8917). I don't have a cluster to run the platform on locally, so this one is from reading the code. Lint passes.