Repository navigation
Wait for the broker schema agent to launch in startBrokerAgent - #254
Merged
Merged
Conversation
startBrokerAgent returned before the agent was launched, so a suspend arriving in that window found nothing to stop and the agent kept running with no record of it. The platform now needs this call to only resolve once the agent is actually up.
This was referenced Oct 14, 2026
cstns
marked this pull request as ready for review
October 14, 2026 10:15
hardillb
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Merge order: this, FlowFuse/driver-localfs#363 and FlowFuse/driver-k8s#415 go first and get released, then FlowFuse/flowfuse#8917 together with bumping the driver versions.
startBrokerAgentkicked offcreateMQttTopicAgentwithout awaiting it, so it resolved before the container existed. A suspend landing in that gap tries to stop a container that isn't there yet, swallows the error, and the container comes up afterwards with no record of it on the platform (FlowFuse/flowfuse#8619). It now awaits the create.Worth knowing: the create pulls the agent image if it's missing, so the very first start on a host now waits for that pull before replying.
Same change as FlowFuse/driver-localfs#363, which I raced against the local app (0 orphans out of 24 together with FlowFuse/flowfuse#8917). I don't have a docker driver setup for the platform locally, so this one is from reading the code. Lint passes.