Skip to content

ci: Run CodSpeed benchmarks in simulation on GitHub-hosted runners - #274

Merged
emyller merged 3 commits into
mainfrom
ci/codspeed-simulation
Oct 30, 2026
Merged

emyller merged 3 commits into
mainfrom
ci/codspeed-simulation

Conversation

@emyller

@emyller emyller commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

CodSpeed never benchmarks main: its run stays queued, as macro runner usage is exceeded, so PRs get no comparison.

Follows #272.

Changes

  • Benchmarks run on ubuntu-latest instead of codspeed-macro.
  • Benchmarks are measured in simulation mode instead of walltime.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@emyller
emyller requested a review from a team as a code owner October 30, 2026 17:22
@emyller
emyller requested review from khvn26 and removed request for a team October 30, 2026 17:22
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d101b272-c187-4746-9aec-b1256e89db7f
Commits

Reviewing files that changed from the base of the PR and between 2a69db4 and e8abaf1.

Files selected for processing: 1
  • .github/workflows/codspeed.yml
Walkthrough

The benchmarks job now runs on ubuntu-latest. The CodSpeed action uses simulation mode. The benchmark command remains make benchmark.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1
.github/workflows/codspeed.yml-37-37: 1

37-37: Minor · Potential issue · Quick win

Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.

The action now requests simulation mode while retaining make benchmark; if that target runs benchmarks instrumented only for walltime collection, the action may collect no usable simulation results.

The run fails or publishes no benchmark measurements, leaving PRs without comparisons despite the runner change.

This can occur when: A benchmark workflow run executes a make benchmark target whose benchmark framework or CodSpeed integration does not support simulation mode.


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 95292818-36a5-4745-b857-f4805a2d6f4d
Commits

Reviewing files that changed from the base of the PR and between 701e8e5 and 2a69db4.

Files selected for processing: 1
  • .github/workflows/codspeed.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@codspeed

codspeed Bot commented Oct 30, 2026

Copy link
Copy Markdown

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if my suggestions make sense to you.

Comment thread .github/workflows/codspeed.yml Resolved
Comment thread .github/workflows/codspeed.yml Resolved
emyller and others added 2 commits October 30, 2026 14:33
Co-authored-by: Kim Gustyr <khvn26@gmail.com>
@emyller
emyller merged commit 4d5c27f into main Oct 30, 2026
8 checks passed
@emyller
emyller deleted the ci/codspeed-simulation branch October 30, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants