Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Detect red-light stop-line entry when the physical front bumper crosses the line. For a 4 m vehicle moving from center x = -2.5 m to -1.5 m toward a stop line at x = 0, the bumper moves from -0.5 m to +0.5 m. The current center-based check misses this entry; this change reports the infraction and therefore applies the existing stop-line penalty at that step.
Why
The current check allows the front of the vehicle to protrude across a red-light stop line without triggering its violation flag or penalty. Front-based entry makes the stopping reference consistent with keeping the vehicle body before the line.
Notes
eval_perceived_size_margin_mchanges observations only; the check usessim_lengthandsim_width, and a regression test covers that distinction.Validation:
make -C tests/drive test: all C unit and environment smoke suites pass.NO_TRAIN=1 python setup.py build_ext --inplace --forceand importing the rebuiltpufferlib.ocean.drive.binding: pass in the existing Docker environment.clang-format --dry-run --Werror(21.1.5) on both changed C files andgit diff --check: pass.