Fix SYMRSVDWORD not renaming module names matching C++ keywords - #2
Open
TJackhammer wants to merge 1 commit into
Open
Fix SYMRSVDWORD not renaming module names matching C++ keywords#2TJackhammer wants to merge 1 commit into
TJackhammer wants to merge 1 commit into
Conversation
The V3Name pass's visit(AstNodeModule*) did not call renameKeywordCheck(), so module names matching C++ reserved words (e.g. "register") passed through to the C++ emitter unchanged, causing a fatal error in V3EmitCSyms::nameCheck(). Add renameKeywordCheck(nodep) to the AstNodeModule visitor, consistent with how AstVar, AstCFunc, and AstCell are already handled. Add test t_mod_rsvd to exercise this path with -fno-inline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register) causes a fatal error in the C++ emitterV3Name.cpp'svisit(AstNodeModule*)did not callrenameKeywordCheck(), unlike the visitors forAstVar,AstCFunc, andAstCellrenameKeywordCheck(nodep)to theAstNodeModulevisitorTest plan
t_mod_rsvdtest with a module namedregisterand-fno-inlineto prevent inliningt_var_rsvd,t_var_rsvd_port, andt_var_rsvd_badtests pass (no regressions)Notes
verilator/verilatorafter internal review🤖 Generated with Claude Code