Add VirtualDom::remount_render_target for a renderer that lost its nodes - #5886
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VirtualDom::remount_render_targetrewrites a render target's whole mounted tree into a fresh writer without re-running any component, for a renderer that lost that target's nodes, such as a webview that reloads its page after an Android activity gets recreated. Component state survives since nothing re-renders, only the DOM gets rebuilt against the new writer.A
Portalnested inside the content being recovered can point at a completely different, still-live render target. Both the removal and the creation walk this primitive runs are scoped to the target actually being recovered, so a sibling target reached that way is never touched, its scope, mount and DOM stay exactly as they were before the call.Missing that boundary would leave a live sibling window or modal with a second, permanently untracked copy of its own content, since the renderer's own element-id bookkeeping for that mount would get overwritten to point at newly created nodes while the originals lose their only reference.
Part of #5885, first step of the Android fix.