Redraw a webview page that replaces an earlier one - #5863
Open
LucaCappelletti94 wants to merge 4 commits into
Open
LucaCappelletti94 wants to merge 4 commits into
LucaCappelletti94 wants to merge 4 commits into
Conversation
LucaCappelletti94
force-pushed
the
upstream/android-activity-recreation
branch
3 times, most recently
from
October 3, 2026 11:26
272a719 to
aaccbe0
Compare
LucaCappelletti94
force-pushed
the
upstream/android-activity-recreation
branch
from
October 3, 2026 11:40
aaccbe0 to
31e5ed8
Compare
LucaCappelletti94
marked this pull request as draft
October 3, 2026 11:53
6 tasks
LucaCappelletti94
marked this pull request as ready for review
October 3, 2026 16:22
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recreated Android activity gets a new webview that reloads the page, but Dioxus never refilled it. The #4422 guard blocked the second load,
initializeonly triggered a rebuild once, and the edit queue waited forever for an ack from the dead page.Each page desktop serves gets an increasing id. When a page's
initializecallback fires, desktop ignores it if the id belongs to a page that was already replaced or already initialized once. For an actual replacement page, it opens a fresh edits connection, writes the page's head elements, then callsVirtualDom::remount_render_target(introduced in #5886) to redraw the body. Only Android may load the index again, so desktop keeps #4422's behaviour there.DOM-only state and pending
evalqueries do not survive. Tested on a Galaxy M52 (fresh install, asset-path change, dark mode, font scale).Since this PR is "stacked" on #5862 and #5886, review only the last two commits (the webview redraw and the connection-reset tests).
Part of #5885, resolves the Android portion of the issue.