Keep ndk_context valid across Android activity recreation - #5862
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Android recreates the activity, for example for the asset-path change right after a fresh install, the process survives but
ndk_contextstill points at the first activity's global ref, which wry has freed. The next asset load crashes under CheckJNI and is undefined behaviour in release.ndk_contextnow holds the Application context, which lives as long as the process.manganis::android::with_activityreads a current-activity slot thatdioxus-desktopupdates on every activity (hence the new Android-onlymanganisdependency), so plugins no longer get a destroyed activity. The manifest template also declares the configuration changes the WebView applies live (smallestScreenSize, keyboard, navigation, touchscreen, density), extending #3905.#5356 also suggested renaming
with_activitytowith_context, since a plainContextis all the JNI call actually needs. This PR fixes the crash but keeps the old name, since a public API rename is a call for a maintainer rather than something to fold into a crash fix.A recreated activity still shows a blank page (#5885). A stacked follow-up PR (#5863) fixes that, I separated it mostly to keep this PR as small as possible.
ndk-contexthad no commits since 2022 and its CI hadn't run in the same span. I opened a stack reviving it: #7 brings CI back to green, #6 replaces astatic mutwith aRwLock(fixing a real data race Miri reports), and #8 adds thetry_*accessors this patch wants, so callers stop needingcatch_unwind. All three are open and unreviewed so far. Separately, crates.io publish ownership for this crate has been stuck with an unresponsive original owner since #2 (May 2025), so even a merged PR can't ship a release until that's resolved too.Given both, this patch should be treated as the durable shape of the workaround, not a stopgap waiting on an imminent upstream fix. Personally, I suggest to vendor
ndk-contextinto a new crate agreed upon by the majority of the downstream users.Fixes #5356