Skip to content

Fix #733: use PowerShell Move-Item for cross-volume directory on Windows #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khurram-saeed-malik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #733: use PowerShell Move-Item for cross-volume directory on Windows #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions code/common/os.q
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,21 @@ hdeldir:{[dirpath;pdir]
.lg.o[`deldir;"deleting from directory : ",dirpath];
hdel each desc filelist}
md:{if[not Fex x;system"mkdir \"",pth[x],"\""]};
ren:{system("mv ";"move ")[NT],pth[x]," ",pth y}
cpy:{system("cp ";"copy ")[NT],pth[x]," ",pth y}
Vex:not 0h~type key`.@
df:{(`$("/";"\\")[NT]sv -1_v;`$-1#v:("/";"\\")[NT]vs pth(string x;x)[10h=type x])}
run:{system"q ",x}
kill:{[p]@[(`::p);"\\\\";1];}
sleep:{x:string x; system("sleep ",x;"timeout /t ",x," >nul")[NT]}
pthq:{[x] $[10h=type x;ssr [x;"\\";"/"];`$ -1 _ ssr [string (` sv x,`);"\\";"/"]]}
pthq:{[x] $[10h=type x;ssr [x;"\\";"/"];`$ -1 _ ssr [string (` sv x,`);"\\";"/"]]}
ren:{[x;y]
/ Convert the incoming q values into OS path strings.
src:pth x;
dst:pth y;
/ On non-Windows platforms a normal mv already handles file and directory renames.
if[not NT;
:system "mv \"",src,"\" \"",dst,"\""];
/ Escape single quotes so a path can be embedded safely in a PowerShell literal string.
psqlit:{[p] "'",ssr[p;"'";"''"],"'"};
/ Move-Item gives us native Windows move semantics for files, directories and cross-volume moves.
:system "powershell -NoProfile -Command Move-Item -LiteralPath ",psqlit[src]," -Destination ",psqlit[dst]}