Fix #733: use PowerShell Move-Item for cross-volume directory on Windows#734
Open
khurram-saeed-malik wants to merge 1 commit intoDataIntellectTech:masterfrom
Open
Conversation
…directory moves on Windows Replace the robocopy-based .os.ren implementation with a simpler and more robust approach using PowerShell's Move-Item cmdlet. Move-Item natively handles: - File renames/moves - Directory renames/moves - Cross-volume moves (different Windows drives/disks) This fixes the WDB default writedown mode workflow when the WDB path and HDB path reside on different Windows drives/volumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733
Problem
On Windows,
.os.renused amovecommand that fails when the sourceand destination are on different drives/volumes. This breaks WDB default
writedown mode when the WDB path and HDB path reside on different disks.
Solution
Replace the old Windows
move-based implementation with PowerShell'sMove-Itemcmdlet, which natively handles:The Unix path (
mv) is unchanged.Files Changed
code/common/os.q- updated.os.renContributor
Arseni Maiorov
https://github.com/mayoroff