Skip to content

feat(openfeature): prepare evaluator-gated dependent flag negotiation - #11038

Draft
hhan2024 wants to merge 4 commits into
masterfrom
helen/dependent-flags-capabilities-node
Draft

hhan2024 wants to merge 4 commits into
masterfrom
helen/dependent-flags-capabilities-node

Conversation

@hhan2024

@hhan2024 hhan2024 commented Nov 2, 2026

Copy link
Copy Markdown

What does this PR do?

Gate the agentless X-DD-FEATURE-FLAGS-CAPABILITIES: dependent-flag-variant-key-v1 header and RC bit 50 on one evaluator capability report. The report remains empty until the bundled evaluator and tracer hooks implement prerequisite evaluation, error propagation, and exposure semantics; current requests and RC bit 46 are unchanged.

Motivation

Follows Python agentless #21335 and Python RC #21336.

Additional Notes

Added positive/unknown/empty transport cases, initial and conditional HTTP request coverage, and an unsupported-evaluator regression check. Syntax checks and direct evaluator-report/RC-bit assertions pass; npm run test:openfeature cannot run because test dependencies (including Mocha) are not installed, and workspace storage is exhausted. Keep draft until the suites and lint pass in CI.

Gate configuration negotiation on evaluation and exposure support; the current evaluator remains opted out.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
@dd-octo-sts

dd-octo-sts Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.75 MB
Deduped: 10.5 MB
No deduping: 10.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.5.3 | 131.25 kB | 531.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 98.30% (-0.06%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6980d2f | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.99%. Comparing base (bf5e267) to head (6980d2f).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11038      +/-   ##
==========================================
+ Coverage   98.98%   98.99%   +0.01%     
==========================================
  Files        1079     1087       +8     
  Lines      177113   178761    +1648     
  Branches       72       82      +10     
==========================================
+ Hits       175316   176973    +1657     
+ Misses       1796     1787       -9     
  Partials        1        1              
Flag Coverage Δ
ai-guard 63.75% <81.25%> (+0.03%) ⬆️
apm-capabilities 54.77% <100.00%> (-0.10%) ⬇️
apm-integrations 81.06% <81.25%> (-0.01%) ⬇️
appsec 57.35% <81.25%> (-0.18%) ⬇️
debugger 70.84% <81.25%> (+0.07%) ⬆️
instrumentation 55.61% <81.25%> (-0.18%) ⬇️
llmobs 81.83% <81.25%> (+0.46%) ⬆️
master-coverage 98.99% <100.00%> (?)
openfeature 67.73% <100.00%> (+0.13%) ⬆️
platform 68.42% <81.25%> (+0.12%) ⬆️
profiling 65.85% <81.25%> (+0.01%) ⬆️
serverless 64.79% <81.25%> (-0.07%) ⬇️
test-optimization 82.24% <81.25%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-11-04 21:37:44

Comparing candidate commit 6980d2f in PR branch helen/dependent-flags-capabilities-node with baseline commit bf5e267 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2447 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable max_rss_usage [-2.205MB; +44.703MB] or [-0.781%; +15.823%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-26

  • unstable max_rss_usage [-30.526MB; +13.417MB] or [-11.066%; +4.864%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • unstable max_rss_usage [-12.566MB; +36.735MB] or [-3.547%; +10.369%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-26

  • unstable max_rss_usage [-35.242MB; -0.324MB] or [-11.634%; -0.107%]

scenario:debugger-line-probe-with-snapshot-default-20

  • unstable max_rss_usage [-5.847MB; +8.396MB] or [-4.394%; +6.310%]

scenario:openfeature-initialization-configuration-26

  • unstable cpu_user_time [-184.698ms; +113.461ms] or [-10.659%; +6.548%]
  • unstable execution_time [-180.929ms; +114.143ms] or [-10.080%; +6.359%]
  • unstable throughput [-28907.917op/s; +51724.117op/s] or [-5.079%; +9.088%]

scenario:openfeature-initialization-error-24

  • unstable max_rss_usage [-8.431MB; +25.606MB] or [-2.959%; +8.985%]

scenario:openfeature-typical-full-24

  • unstable max_rss_usage [-17.405MB; +29.757MB] or [-6.850%; +11.712%]

@aarsilv aarsilv added the crucible: reviewing A Crucible review has started; this PR has reviewer attention. label Nov 4, 2026
// The bundled evaluator and tracer hooks must support prerequisite evaluation,
// error propagation, and exposure reporting before this report can opt in.
function getEvaluatorCapabilities () {
return []

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Comment from Claude working with Aaron Silverman:

[P1] Coordination note with #10749: no PR in the stack turns this report on.

#10749 adds the dependent-flag provider, but it does not change this function and adds no query parameter, header or bit of its own. With both PRs merged, Node does not advertise dependent-flag support on either delivery path, and the backend leaves dependent flags out.

Suggested order: land this PR first. Then #10749 changes this function to return [DEPENDENT_FLAG_VARIANT_KEY_V1] once its published provider supports dependent flags.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crucible: reviewing A Crucible review has started; this PR has reviewer attention. semver-minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants