Skip to content

feat(openfeature): request dependent flags with query parameter - #11083

Merged
typotter merged 1 commit into
helen/dependent-flags-capabilities-nodefrom
typo/dependent-flags-query-param-node
Nov 4, 2026
Merged

typotter merged 1 commit into
helen/dependent-flags-capabilities-nodefrom
typo/dependent-flags-query-param-node

Conversation

@typotter

@typotter typotter commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Uses cap_dependent-flags-variant-key=v1 on direct UFC requests when the evaluator reports dependent-flag support. It preserves existing query parameters and does not send the dependent-flags capability header to UFC.

Motivation

Keep the capabilities header scoped to client SDK → Edge Assignments negotiation while direct UFC consumers negotiate response shape through the cache-keyed URL.

Additional Notes

Stacked on #11038 for an independently reviewable transport-only diff.

Validation: NODE_PATH=/home/bits/go/src/github.com/DataDog/dd-trace-js/node_modules /home/bits/go/src/github.com/DataDog/dd-trace-js/node_modules/.bin/mocha packages/dd-trace/test/openfeature/agentless_configuration_source.spec.js packages/dd-trace/test/openfeature/evaluator-capabilities.spec.js (30 passing).

@dd-octo-sts

dd-octo-sts Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.8 MB
Deduped: 10.55 MB
No deduping: 10.55 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.5.3 | 131.25 kB | 531.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@typotter
typotter marked this pull request as ready for review November 4, 2026 19:35
@typotter
typotter requested a review from a team as a code owner November 4, 2026 19:35
@typotter
typotter merged commit 277d831 into helen/dependent-flags-capabilities-node Nov 4, 2026
678 of 705 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T19:36:59.642728Z b0009f7 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-04T19:37:59.443491Z b0009f7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@typotter
typotter deleted the typo/dependent-flags-query-param-node branch November 4, 2026 19:35
@pr-commenter

pr-commenter Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-11-04 21:35:48

Comparing candidate commit bbbd87d in PR branch typo/dependent-flags-query-param-node with baseline commit 02c64b0 in branch helen/dependent-flags-capabilities-node.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2448 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable max_rss_usage [-24.764MB; +16.918MB] or [-8.258%; +5.642%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-24

  • unstable max_rss_usage [-31.610MB; +12.238MB] or [-9.402%; +3.640%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • unstable max_rss_usage [-28.868MB; +43.024MB] or [-8.195%; +12.214%]

scenario:openfeature-initialization-configuration-20

  • unstable max_rss_usage [-3.079MB; +6.044MB] or [-4.157%; +8.159%]

scenario:openfeature-initialization-configuration-26

  • unstable cpu_user_time [-118.063ms; +179.934ms] or [-6.956%; +10.602%]
  • unstable execution_time [-120.505ms; +185.466ms] or [-6.863%; +10.563%]
  • unstable throughput [-50924.385op/s; +33519.735op/s] or [-8.764%; +5.769%]

scenario:openfeature-scale-full-26

  • unstable max_rss_usage [-21.565MB; +31.291MB] or [-10.815%; +15.694%]

scenario:openfeature-typical-full-20

  • unstable max_rss_usage [-11.327MB; +5.320MB] or [-7.150%; +3.358%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant