Repository navigation
Add exact P104 ADD-coefficient fault localization (no new κ) - #6175
Merged
Mister-Meeseeks merged 1 commit intoOct 29, 2026
Merged
Conversation
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an exact diagnostic for PR5568's open question about identifying the event behind a wrong ADD value. Given a P104 scalar endpoint discrepancy, it returns every single ADD coefficient replacement that repairs the complete map. Ambiguous repairs remain explicit. A zero residual does not certify absence of invisible faults.
Claim type: scoped diagnostic correctness proof with finite evidence. No new kappa, supplier, predecessor audit or selected-frontier change. The source-bound example changes event 0 of PR5561's word from -2 to -1. The new diagnostic returns exactly event 0 with replacement -2, restoring all 743 scalar outputs on all 735 independent public inputs. The new application and code are produced by Nick Petalas.
Package:
research/p104-add-fault-localization/. Base: canonical main3f0152a32eeebac0df11946dbd50cabe5a7f7839, priority revision 8, refreshed before publication. The replay-runtime card is explicitly changed from speed to diagnostic capability. Advance CLAIM.Evidence
045350fba7915f964248ca95f996eff3acc08239, covering nine package/input files. The official export and declared-input integrity check pass. Optimized replay passes with Git absent and exported files read-only; all ten exported files, including the export manifest, retain their bytes and executable bits. Altered receipt and source bytes are rejected under optimization.Exact reproduction from the repository root, CPython 3.12.15 and standard library only:
Expected markers:
PASS_P104_ADD_FAULT_LOCALIZATION,PASS_REGISTERED_RESEARCH_PACKAGE, andPASS_RESEARCH_COMMIT_BYTES.RESULT.jsonis generated and bound to package/input hashes. Ordinary verification writes no files.Limitations and unrun obligations
Completeness concerns one changed ADD coefficient in the declared rational scalar program. Wrong operands, several faults, chronology changes and native/frame faults are excluded. COPY/INIT/CLEAR have their stated scalar semantics; their physical legality is not certified. The coefficient-rule flag checks only nonzero dyadic size admissibility. Native phases, owning legality, precision, tape, caller, compiler, BIT and outer suites were not run. Independent human and formal proof-kernel review are unclaimed. No runtime gain is claimed.
Credit DreamingOfClouds / PR5568 for the question and tooling; Ali Romman / PR5544/5545 and PR5392, thu-nmrc / PR5551, PR5553/5561 and GamingPuzzled / PR5472 for the retained word lineage. Credit woklerx / PR1017 and Sagar Thakrar / PR762 for prior fault-testing and prefix/suffix sensitivity. The standard rank-one identity is not claimed as new. No predecessor implementation is copied or changed.
Open next questions
Related open work
Add P104 designer toolkit v2: exact pricing and legality, #6030 rebuild with fold/hoist/retain, generators, sub-circuit tools (no kappa claim) #6170 packages the P104 designer toolkit; this adds exact single-coefficient localization beside its endpoint-only oracle, without changing that toolkit.
No new κ: exact multi-gate resynthesis removes 117 P104 events #6169 applies multi-gate coefficient resynthesis on PR6144. This diagnostic solves a single-coefficient repair question; it supplies no simultaneous-edit or feedback optimization.
Conditional κ = 0.003128645 (+2.59e-7 over #6144): retain an operand to remove a root stop #6167 changes retained-operand chronology; its word and kappa are not replayed or compared here.
Conditional κ .003128386 (+2.582e-6 over #6030): owned registers 770, 771 and 772 descend through the frames of helpers 705, 706 and 731, which no longer relay them; helper 732 reads 771 at frame 117 #6144 changes owned-register descents; this diagnostic uses the older PR5561 scalar fixture and makes no invoice comparison.
Conditional κ 0.00309871 from a prepared P104 split helper #5606 proposes a prepared P104 helper split; no split, target credit or supplier claim is checked here.
Two successor hand-offs on the P104 word: conditional κ 0.0030428242 #5553 supplies a P104 handoff predecessor retained by the toolkit; this adds a diagnostic on the later pinned PR5561 fixture and does not recertify its construction.
Prove exact two-channel P104 support 72 over F3 and Q (no new κ) #6173 computes two-channel support in a fixed P104 root code; it supplies no ADD-coefficient localization or competing repair count.
Prove stable joint-bank Gram spectral obstruction (no new κ) #6181 proves a joint-bank P104 spectral obstruction; this diagnostic computes no spectral correction rank.
Prove sharp signed tensor gap with variable target boundaries (no new κ) #6172 optimizes an abstract variable-target tensor invoice; this diagnostic keeps the scalar word and desired endpoint fixed and computes no tensor optimum.
Certify rectangular dirty circuits with k+1-coordinate witnesses (no κ) #6180 certifies typed rectangular dirty circuits with independent operators; this diagnostic instead returns coefficient repairs for a fixed rational scalar endpoint.
The completion refresh read this account's open PRs created since the advance CLAIM. No other submission in that list computes the P104 coefficient repair reported here, and no numerical disagreement was found. No extra computations were run to check other contributions.
CI notes
Both hosted checks passed at exact head
045350fba7915f964248ca95f996eff3acc08239in run 40880471561: plan in 3m42s and replay (research/p104-add-fault-localization) in 1m26s. The completed check list was read once and both entries report pass.Hosted replay certifies the registered normal and optimized package checks at this head. All recorded local checks, committed-byte/mode/source-history checks, export integrity and read-only Git-free replay also pass. The scalar fault model, physical-legality limitations and unrun complete-supplier obligations retain their stated scope. Independent human and formal proof-kernel review remain unclaimed.
Merge Danger
Door: two-way. Blast Radius: scoped. Eight new files in one research package; one unchanged declared input. No shared checker, selected certificate or frozen predecessor changes.