Skip to content

test: lock derivative advisory as supply-chain RED - #54

Open
seonghobae wants to merge 75 commits into
build/rust-1.98.1-vtable-fix-v1from
test/rustsec-2024-0388-lock-red-v1
Open

test: lock derivative advisory as supply-chain RED#54
seonghobae wants to merge 75 commits into
build/rust-1.98.1-vtable-fix-v1from
test/rustsec-2024-0388-lock-red-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Refs #13.

Dependency root / non-force ancestry

Ready child of compiler-repair #56 exact 18fb38b1ba70c4bf222642ef347f3d57a98379a2, itself based on foundation #1. Current #54 exact head remains 50b0516a9249c4066e3a0f305dbf2759eae3ae06; effective child scope remains CHANGELOG.md, TEST_STRATEGY.md, docs/doctoring/TRACEABILITY.md, and tests/supply_chain_policy.rs. Parent #56 is exact-head hosted GREEN but still lacks the required independent APPROVED; no self-approval/bypass is used.

Hosted supplier-intake RED — unchanged

CI 33998449940 on exact #54 has GREEN load-contract 101392950922, GREEN OCI 101392951059, and failing test 101392951060. Exact checkout, Rust 1.98.1 and formatting pass; compile/test fails because rustsec_2024_0388_dependency_is_absent_from_committed_lock finds exact package derivative 2.2.0 in committed Cargo.lock. Supply Chain 33998449901 / 101392950711 is GREEN through dependency audit, exact image, SPDX SBOM, image scan and exact-source binding.

RUSTSEC-2024-0388 is an unmaintained-package advisory, not a memory-safety-CVE claim. #54 intentionally adopts a stricter commercial supplier-intake criterion and will not turn GREEN through an ignore, deleted lock evidence, scanner suppression or muted regression.

Independent supplier-semantics control

#62 remains exact 32e0aeedac7b0fe6234d476245f37994b1b9168f and independently hosted/technically GREEN for the required PeerOptions non-hook Debug surface, Backend address+weight equality/hash/order semantics, Rust-only bounded-origin load, OCI/runtime and Supply Chain evidence. #62 does not substitute for #54's package-absence RED and predecessor receipts are not transferred.

Current Pingora main and 0.9.0 publication do not close this root

Protected cloudflare/pingora/main has advanced beyond the release tag to exact 4487f7b2ab50f159e4a2cf4f6a6b813f61bb6e19. The latest published release remains Pingora 0.9.0; lightweight refs/tags/0.9.0 points to 702f69015e53f7244d6ad2e743de571d859a70a4. GitHub Release 0.9.0 was published at 2026-09-09T23:34:48Z (2026-09-10 08:34:48 KST), is not a prerelease, has no attached assets, and is reported as immutable:false.

Neither authority satisfies #54. The released/tagged workspace Cargo.toml@702f690... declares derivative = "2.2.0", and fresh protected-main source at 4487f7b... still declares the same workspace dependency. Owner issue cloudflare/pingora#889 remains open with no maintainer-integrated derivative-removal disposition. Movement on main is therefore supplier-development evidence only, not release-qualified repair authority.

The downstream committed-lock regression must remain RED until a released supplier identity actually removes the package from the resolved production graph. Historical derivative-free manifests are not accepted as drop-in fixes without current compatibility and resolved-lock proof. The supported conclusion remains: neither 0.8.1 nor 0.9.0 satisfies the commercial dependency-absence contract, and the post-0.9.0 moving main has not yet repaired it either.

Required supplier repair remains removal of derivative from the relevant current workspace/core/load-balancing dependency graph and regenerated lock while preserving #62 semantics, followed by supplier fmt/tests/Clippy/rustdoc/audit and release-qualified publication. Supplier source mutation remains maintainer-owned.

Promotion order for this root is #54 committed-lock RED + #62 exact GREEN → maintainer-integrated current supplier derivative removal → release-qualified identity containing that removal → ordinary gateway pin/lock regeneration → unchanged #54 absence regression GREEN + preserved/revalidated #62 GREEN → exact CI/Supply Chain/security/runtime gates → #56 independent approval/governance → normal downstream integration.

No production routing/TLS/HTTP-policy/auth/business-logic change, release, canary, cutover or legacy-removal credit is claimed.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 33638e23-2bd8-4ddd-ab03-2e3619adee2e

📥 Commits

Reviewing files that changed from the base of the PR and between 5a62e2f and 4ee1a5f.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • TEST_STRATEGY.md
  • docs/product-technical-gap-baseline.md
  • tests/supply_chain_policy.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

커밋된 Cargo.lock에서 derivative 패키지의 정확한 레코드를 검사하는 회귀 테스트를 추가했습니다. 테스트의 의도적 RED 상태와 RUSTSEC-2024-0388 제거 조건을 변경 기록, 테스트 전략, 기준 문서에 반영했습니다.

Changes

공급망 정책 검증

Layer / File(s) Summary
잠긴 의존성 검증 계약
tests/supply_chain_policy.rs
정확한 Cargo 패키지 레코드만 조회하는 헬퍼와 검증 테스트를 추가했습니다. derivative-likederivative와 일치하지 않습니다. 커밋된 Cargo.lockderivative가 있으면 RUSTSEC-2024-0388 검증이 실패합니다.
정책 및 추적성 문서
TEST_STRATEGY.md, docs/product-technical-gap-baseline.md, CHANGELOG.md
테스트의 의도적 RED 상태와 GREEN 전환 조건을 문서화했습니다. derivative 제거 책임을 pingora-gateway#13으로 갱신하고 릴리스 차단 조건을 조정했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4ee1a

This change adds a documented supply-chain lockfile contract that remains intentionally RED until derivative is removed from the committed dependency graph; it does not alter production gateway or release behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 tests/supply_chain_policy.rsderivative 의존성을 공급망 RED 상태로 고정하는 핵심 변경을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/rustsec-2024-0388-lock-red-v1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review exact head 8813c761ca5d311b7f2b83a93e9a50aa8bf5e2a5 against exact parent/base 5a62e2fa56fdaa6f97c0518932711739e347c04a. Focus on whether tests/supply_chain_policy.rs matches exact Cargo package records without false positives/negatives and whether the intentional RUSTSEC-2024-0388 RED can only turn GREEN by removing the derivative package from the committed lock graph. This is a Draft RED contract; do not treat the expected current failure as a request to weaken or ignore the advisory.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head="8813c761ca5d311b7f2b83a93e9a50aa8bf5e2a5"
base="5a62e2fa56fdaa6f97c0518932711739e347c04a"

echo "== Exact commits and merge base =="
git cat-file -e "${head}^{commit}"
git cat-file -e "${base}^{commit}"
printf 'merge-base: '
git merge-base "$base" "$head"
printf 'ahead/behind: '
git rev-list --left-right --count "${base}...${head}"

echo
echo "== Changed files =="
git diff --name-status "$base" "$head"

echo
echo "== Full diff =="
git diff --no-ext-diff --unified=80 "$base" "$head" -- \
  tests/supply_chain_policy.rs TEST_STRATEGY.md CHANGELOG.md docs/product-technical-gap-baseline.md

echo
echo "== Test source outline and content at head =="
git show "${head}:tests/supply_chain_policy.rs" > /tmp/supply_chain_policy.rs
ast-grep outline /tmp/supply_chain_policy.rs --items all --view expanded || true
cat -n /tmp/supply_chain_policy.rs

echo
echo "== Exact package records and derivative references in lockfile at head =="
git show "${head}:Cargo.lock" > /tmp/Cargo.lock
awk '
  BEGIN { RS=""; ORS="\n\n" }
  /^\[\[package\]\]/ && $0 ~ /^name = "derivative"$/m { print }
' /tmp/Cargo.lock || true
rg -n -C 4 '(^name = "derivative"$|derivative)' /tmp/Cargo.lock || true

echo
echo "== Test-related configuration and bypass indicators =="
rg -n -i -C 3 \
  '(supply_chain_policy|RUSTSEC-2024-0388|derivative|--ignored|ignore\s*=|cfg\s*\(|CARGO_MANIFEST_DIR|Cargo\.lock|test-threads|autotests)' \
  Cargo.toml .cargo .github tests 2>/dev/null || true

Length of output: 94959


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Manifest: integration-test discovery and lock behavior =="
cat -n Cargo.toml

echo
echo "== CI workflow: trigger and Rust test commands =="
for file in .github/workflows/ci.yml .github/workflows/supply-chain.yml; do
  echo "--- $file ---"
  nl -ba "$file" | sed -n '1,180p'
done

echo
echo "== Advisory policy and possible waiver rules =="
cat -n deny.toml
rg -n -i -C 4 \
  '(RUSTSEC-2024-0388|derivative|ignore|advisor|vulnerab|audit)' \
  deny.toml .github README.md TEST_STRATEGY.md CHANGELOG.md docs 2>/dev/null || true

echo
echo "== Test target declarations and test invocation exceptions =="
rg -n -C 3 \
  '^\s*\[\[test\]\]|^\s*autotests\s*=|cargo\s+(test|llvm-cov)|--test|--exclude|--ignored|supply_chain_policy' \
  Cargo.toml .github tests 2>/dev/null || true

echo
echo "== Package-record count using a TOML-safe structural check =="
python3 - <<'PY'
from pathlib import Path
lock = Path("Cargo.lock").read_text(encoding="utf-8")
records = []
for segment in lock.split("[[package]]")[1:]:
    fields = {}
    for line in segment.splitlines():
        line = line.strip()
        if line.startswith('name = "') and line.endswith('"'):
            fields["name"] = line[len('name = "'):-1]
        elif line.startswith('version = "') and line.endswith('"'):
            fields["version"] = line[len('version = "'):-1]
    records.append(fields)
print([record for record in records if record.get("name") == "derivative"])
PY

Length of output: 3166


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== CI workflow =="
cat -n .github/workflows/ci.yml

echo
echo "== Supply-chain workflow =="
cat -n .github/workflows/supply-chain.yml

echo
echo "== Dependency policy =="
cat -n deny.toml

echo
echo "== Advisory waivers and test execution controls =="
rg -n -i -C 4 \
  '(RUSTSEC-2024-0388|derivative|ignore|advisories|vulnerabilities|cargo\s+(test|llvm-cov)|--test|--exclude|--ignored|autotests)' \
  Cargo.toml deny.toml .github tests 2>/dev/null || true

echo
echo "== Exact derivative package records =="
awk '
  BEGIN { in_pkg=0; name=""; version="" }
  /^\[\[package\]\]$/ {
    if (in_pkg && name == "derivative") {
      printf("name=%s version=%s\n", name, version)
    }
    in_pkg=1; name=""; version=""; next
  }
  in_pkg && /^name = "/ {
    value=$0; sub(/^name = "/, "", value); sub(/"$/, "", value); name=value
  }
  in_pkg && /^version = "/ {
    value=$0; sub(/^version = "/, "", value); sub(/"$/, "", value); version=value
  }
  END {
    if (in_pkg && name == "derivative") {
      printf("name=%s version=%s\n", name, version)
    }
  }
' Cargo.lock

Length of output: 25855


@seonghobae No actionable findings.

I verified the requested base and head. 5a62e2fa56fdaa6f97c0518932711739e347c04a is the merge base. 8813c761ca5d311b7f2b83a93e9a50aa8bf5e2a5 is four commits ahead. The delta contains the stated four files.

tests/supply_chain_policy.rs matches package records by an exact name = "derivative" field inside [[package]] blocks. The fixture proves that neither dependencies = ["derivative"] nor name = "derivative-like" matches. This prevents the specified false positives.

The committed Cargo.lock has exactly one matching package record:

[[package]]
name = "derivative"
version = "2.2.0"

The test has no ignore attribute or conditional-compilation bypass. Cargo automatically discovers the integration test. CI runs cargo test --all-targets --locked after checkout of the exact PR head. CI also verifies that Cargo.lock remains unchanged.

The policy has ignore = []. The supply-chain workflow runs cargo deny check advisories licenses sources bans. Trivy sets ignore-unfixed: false. An advisory suppression cannot make this test GREEN.

Therefore, for a valid locked CI execution, this RED contract can turn GREEN only when the committed lock graph no longer contains a derivative package record. The current derivative 2.2.0 record correctly keeps the contract RED.

I did not execute repository code because the sandbox does not permit compilation or test execution. Exact-head hosted execution remains required to establish the expected RED result.

⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Supersedes the earlier review request after forward-only documentation and TRACEABILITY repairs. Review exact head 4f1624134b589ad4eda857a19239d3030f42beca against exact parent/base 5a62e2fa56fdaa6f97c0518932711739e347c04a (fresh compare ahead 8 / behind 0, exact merge base). Focus on tests/supply_chain_policy.rs exact-package matching and false-negative/false-positive risks, whether docs/doctoring/TRACEABILITY.md accurately treats RUSTSEC-2024-0388 as INFO Unmaintained with no patched versions, and whether documentation preserves the separation between .github#1605 (lru intake policy) and pingora-gateway#13 (derivative / RUSTSEC-2024-0388). The current derivative failure is intentional RED; weakening or ignoring it is not a fix.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='5a62e2fa56fdaa6f97c0518932711739e347c04a'
head='4ee1a5feea115587f9fcc5254394b5b86a87d725'

echo '== Exact revision relationship =='
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf 'merge-base: '
git merge-base "$base" "$head"
printf 'ahead/behind: '
git rev-list --left-right --count "${base}...${head}"

echo
echo '== Changed files =='
git diff --name-status "$base" "$head"

echo
echo '== Requested delta =='
git diff --no-ext-diff --unified=100 "$base" "$head" -- \
  tests/supply_chain_policy.rs TEST_STRATEGY.md CHANGELOG.md docs/product-technical-gap-baseline.md

echo
echo '== Supply-chain test source at exact head =='
git show "${head}:tests/supply_chain_policy.rs" > /tmp/supply_chain_policy.rs
ast-grep outline /tmp/supply_chain_policy.rs --items all --view expanded || true
cat -n /tmp/supply_chain_policy.rs

echo
echo '== Test discovery and bypass controls =='
git show "${head}:Cargo.toml" > /tmp/Cargo.toml
cat -n /tmp/Cargo.toml
printf '\n-- matching configuration references --\n'
rg -n -i -C 3 \
  '(supply_chain_policy|autotests|^\s*\[\[test\]\]|--ignored|--exclude|cargo\s+test|RUSTSEC-2024-0388|derivative)' \
  Cargo.toml .github tests deny.toml 2>/dev/null || true

echo
echo '== Exact Cargo.lock package records =='
git show "${head}:Cargo.lock" > /tmp/Cargo.lock
python3 - <<'PY'
from pathlib import Path
lock = Path("/tmp/Cargo.lock").read_text(encoding="utf-8")
records = []
for raw in lock.split("[[package]]")[1:]:
    fields = {}
    for line in raw.splitlines():
        if line.startswith("name = ") or line.startswith("version = ") or line.startswith("dependencies = "):
            fields.setdefault("raw_fields", []).append(line)
        if line.startswith('name = "') and line.endswith('"'):
            fields["name"] = line[8:-1]
        elif line.startswith('version = "') and line.endswith('"'):
            fields["version"] = line[11:-1]
    records.append(fields)
matches = [r for r in records if r.get("name") == "derivative"]
print(f"exact derivative package records: {len(matches)}")
for record in matches:
    print(f'name={record.get("name")!r}, version={record.get("version")!r}')
PY
rg -n -C 3 '(^\[\[package\]\]$|^name = "derivative"$|derivative)' /tmp/Cargo.lock || true

echo
echo '== Documentation ownership references at exact head =='
for path in TEST_STRATEGY.md CHANGELOG.md docs/product-technical-gap-baseline.md; do
  echo "--- ${path} ---"
  git show "${head}:${path}" | rg -n -i -C 4 \
    '(1605|`#13`|derivative|RUSTSEC-2024-0388|\blru\b|intake|owner|canonical)' || true
done

Length of output: 99664


@seonghobae No actionable findings.

I verified that 5a62e2fa56fdaa6f97c0518932711739e347c04a is the merge base of 4ee1a5feea115587f9fcc5254394b5b86a87d725. The exact head is seven commits ahead and zero commits behind. The delta contains the four stated files.

tests/supply_chain_policy.rs checks each [[package]] block and compares the complete name value with "derivative". The fixture proves that both dependencies = ["derivative"] and name = "derivative-like" do not match. This prevents the requested false positives.

The test returns a version for the first exact package record. That behavior is sufficient for this absence contract. If any exact derivative package record exists, the function returns Some(...) and the policy test remains RED. Therefore, duplicate exact package records also cannot produce a false GREEN.

The committed Cargo.lock contains exactly one exact record:

[[package]]
name = "derivative"
version = "2.2.0"

The current implementation therefore fails as intended. The test has no ignore attribute or conditional bypass. CI invokes cargo test --all-targets --locked, so Cargo discovers the integration test and uses the committed lockfile.

The documentation now preserves the required ownership separation:

  • ContextualWisdomLab/.github#1605 owns the exact Pingora versus patched lru / RUSTSEC-2026-0253 policy decision.
  • pingora-gateway#13 owns removal of derivative 2.2.0 / RUSTSEC-2024-0388.
  • The documentation states that the package record must disappear. It also states that advisory suppression cannot satisfy this contract.

The sandbox cannot compile or run the Rust test. Exact-head hosted execution is still required to establish the expected RED result.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae changed the base branch from feat/initial-pingora-runtime to build/rust-1.98.1-vtable-fix-v1 September 4, 2026 11:53

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review the current exact child range 955b3e98e1f1bd945a05b8a7cdd5f16e75c99c77...38f69345830323084915ac9abe66e3f5a9d3c0d6. The parent formatting repair has been adopted non-force; effective child delta must remain exactly CHANGELOG.md, TEST_STRATEGY.md, docs/doctoring/TRACEABILITY.md, and tests/supply_chain_policy.rs. Treat derivative absence as the intentional semantic RED and flag any unrelated format/compiler/bootstrap or contract weakness separately. Do not transfer predecessor review credit.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='955b3e98e1f1bd945a05b8a7cdd5f16e75c99c77'
head='38f69345830323084915ac9abe66e3f5a9d3c0d6'

echo '== Revision relationship =='
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf 'merge-base: '
git merge-base "$base" "$head"
printf 'ahead/behind: '
git rev-list --left-right --count "${base}...${head}"

echo
echo '== Effective child delta =='
git diff --name-status "$base" "$head"
echo
git diff --check "$base" "$head"
echo
git diff --no-ext-diff --unified=100 "$base" "$head" -- \
  CHANGELOG.md TEST_STRATEGY.md docs/doctoring/TRACEABILITY.md tests/supply_chain_policy.rs

echo
echo '== Contract source at exact child head =='
git show "${head}:tests/supply_chain_policy.rs" > /tmp/supply_chain_policy.rs
ast-grep outline /tmp/supply_chain_policy.rs --items all --view expanded || true
cat -n /tmp/supply_chain_policy.rs

echo
echo '== Lockfile exact package records at child head =='
git show "${head}:Cargo.lock" > /tmp/Cargo.lock
python3 - <<'PY'
from pathlib import Path
lock = Path("/tmp/Cargo.lock").read_text(encoding="utf-8")
records = []
for raw in lock.split("[[package]]")[1:]:
    fields = {}
    for line in raw.splitlines():
        if line.startswith('name = "') and line.endswith('"'):
            fields["name"] = line[8:-1]
        elif line.startswith('version = "') and line.endswith('"'):
            fields["version"] = line[11:-1]
    records.append(fields)
for target in ("derivative", "derivative-like"):
    matches = [r for r in records if r.get("name") == target]
    print(f"{target}: {len(matches)} exact records; versions={[r.get('version') for r in matches]}")
PY
rg -n -C 3 '(^\[\[package\]\]$|^name = "derivative"$|derivative)' /tmp/Cargo.lock || true

echo
echo '== Test discovery and bypass controls at child head =='
git show "${head}:Cargo.toml" > /tmp/Cargo.toml
git show "${head}:deny.toml" > /tmp/deny.toml
cat -n /tmp/Cargo.toml
printf '\n-- policy --\n'
cat -n /tmp/deny.toml
printf '\n-- relevant tracked configuration --\n'
rg -n -i -C 3 \
  '(supply_chain_policy|autotests|^\s*\[\[test\]\]|--ignored|--exclude|cargo\s+test|RUSTSEC-2024-0388|derivative|ignore\s*=)' \
  Cargo.toml deny.toml .github tests 2>/dev/null || true

echo
echo '== Requested documentation at exact child head =='
for path in CHANGELOG.md TEST_STRATEGY.md docs/doctoring/TRACEABILITY.md; do
  echo "--- ${path} ---"
  git show "${head}:${path}" > "/tmp/$(basename "$path")"
  rg -n -i -C 5 \
    '(RUSTSEC-2024-0388|derivative|unmaintained|patched|no patched|1605|pingora-gateway#13|\.github#1605|\blru\b|supply_chain_policy)' \
    "/tmp/$(basename "$path")" || true
done

Length of output: 86942


🤖 web_search executed:

RUSTSEC-2024-0388 derivative advisory classification informational unmaintained patched versions RustSec

Length of output: 4344


@seonghobae No actionable findings.

I reviewed 955b3e98e1f1bd945a05b8a7cdd5f16e75c99c77...38f69345830323084915ac9abe66e3f5a9d3c0d6 independently.

The base commit is the merge base of the child head. The child contains 16 commits not in the base. The effective delta contains exactly these four files:

  • CHANGELOG.md
  • TEST_STRATEGY.md
  • docs/doctoring/TRACEABILITY.md
  • tests/supply_chain_policy.rs

git diff --check reported no whitespace errors.

tests/supply_chain_policy.rs splits the lockfile into [[package]] blocks. It compares the complete trimmed name = "..." field to "derivative". The fixture confirms that both a dependency mention and name = "derivative-like" do not match.

The committed Cargo.lock contains one exact package record:

[[package]]
name = "derivative"
version = "2.2.0"

The lookup returns Some("2.2.0") for that record. The absence assertion therefore remains RED. Duplicate valid exact package records also remain RED because the first matching record returns a version. The test has no #[ignore] attribute or conditional bypass. CI runs cargo test --all-targets --locked. deny.toml contains ignore = [].

docs/doctoring/TRACEABILITY.md correctly states that RUSTSEC-2024-0388 is INFO Unmaintained and has no patched versions. The RustSec advisory confirms both facts. The documentation also keeps the ownership separate:

  • ContextualWisdomLab/.github#1605 covers the lru intake-policy decision.
  • pingora-gateway#13 covers removal of derivative and RUSTSEC-2024-0388.

I found no unrelated formatting, compiler, bootstrap, or contract weakness in this child range. I did not execute repository code. Hosted CI must still establish the expected intentional RED result.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Current exact child review range is 1b77f38e33f1131bc58222ae838baae56a078651...acb0368ac8efd0e4d1a75f56be391520d58a7edc. Effective child delta must remain the four derivative-policy files only; predecessor review does not transfer across the non-force parent restack.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='1b77f38e33f1131bc58222ae838baae56a078651'
head='acb0368ac8efd0e4d1a75f56be391520d58a7edc'

echo '== Revision relationship =='
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf 'merge-base: '
git merge-base "$base" "$head"
printf 'ahead/behind: '
git rev-list --left-right --count "${base}...${head}"

echo
echo '== Effective child delta =='
git diff --name-status "$base" "$head"
echo
git diff --check "$base" "$head"

echo
echo '== Full effective child diff =='
git diff --no-ext-diff --unified=100 "$base" "$head" -- \
  CHANGELOG.md TEST_STRATEGY.md docs/doctoring/TRACEABILITY.md tests/supply_chain_policy.rs

echo
echo '== Test source at child head =='
git show "${head}:tests/supply_chain_policy.rs" > /tmp/supply_chain_policy.rs
ast-grep outline /tmp/supply_chain_policy.rs --items all --view expanded || true
cat -n /tmp/supply_chain_policy.rs

echo
echo '== Committed lockfile package records at child head =='
git show "${head}:Cargo.lock" > /tmp/Cargo.lock
python3 - <<'PY'
from pathlib import Path
lock = Path("/tmp/Cargo.lock").read_text(encoding="utf-8")
records = []
for raw in lock.split("[[package]]")[1:]:
    fields = {}
    for line in raw.splitlines():
        if line.startswith('name = "') and line.endswith('"'):
            fields["name"] = line[8:-1]
        elif line.startswith('version = "') and line.endswith('"'):
            fields["version"] = line[11:-1]
    records.append(fields)
for package in ("derivative", "derivative-like"):
    matches = [r for r in records if r.get("name") == package]
    print(f"{package}: count={len(matches)}, versions={[r.get('version') for r in matches]}")
PY
rg -n -C 3 '(^\[\[package\]\]$|^name = "derivative"$|derivative)' /tmp/Cargo.lock || true

echo
echo '== Test discovery and bypass controls =='
git show "${head}:Cargo.toml" > /tmp/Cargo.toml
git show "${head}:deny.toml" > /tmp/deny.toml
cat -n /tmp/Cargo.toml
echo '-- deny.toml --'
cat -n /tmp/deny.toml
echo '-- relevant configuration --'
rg -n -i -C 3 \
  '(supply_chain_policy|autotests|^\s*\[\[test\]\]|--ignored|--exclude|cargo\s+test|RUSTSEC-2024-0388|derivative|ignore\s*=)' \
  Cargo.toml deny.toml .github tests 2>/dev/null || true

echo
echo '== Documentation claims at child head =='
for path in CHANGELOG.md TEST_STRATEGY.md docs/doctoring/TRACEABILITY.md; do
  echo "--- ${path} ---"
  git show "${head}:${path}" > "/tmp/$(basename "$path")"
  rg -n -i -C 5 \
    '(RUSTSEC-2024-0388|derivative|unmaintained|patched|no patched|1605|pingora-gateway#13|\.github#1605|\blru\b|supply_chain_policy)' \
    "/tmp/$(basename "$path")" || true
done

Length of output: 86911


🤖 web_search executed:

RustSec RUSTSEC-2024-0388 derivative advisory informational unmaintained patched versions

Length of output: 4067


@seonghobae No actionable findings.

I reviewed 1b77f38e33f1131bc58222ae838baae56a078651...acb0368ac8efd0e4d1a75f56be391520d58a7edc independently.

The requested base is the merge base. The head is 18 commits ahead and zero commits behind. The effective child delta contains exactly these files:

  • CHANGELOG.md
  • TEST_STRATEGY.md
  • docs/doctoring/TRACEABILITY.md
  • tests/supply_chain_policy.rs

git diff --check reported no whitespace errors.

tests/supply_chain_policy.rs splits the lockfile into [[package]] blocks. It compares the complete parsed package name to "derivative". The fixture confirms that dependencies = ["derivative"] and name = "derivative-like" do not match. This prevents the relevant false positives.

The committed Cargo.lock contains one exact record for derivative 2.2.0. The absence assertion therefore remains intentionally RED. If multiple valid exact records exist, the first exact match still returns Some(version), so the test cannot become GREEN while any such record remains. CI discovers the integration test through cargo test --all-targets --locked. No ignore attribute or conditional bypass exists. deny.toml has ignore = [].

docs/doctoring/TRACEABILITY.md correctly states that RUSTSEC-2024-0388 is INFO Unmaintained and has no patched versions. RustSec confirms both facts. The documentation also preserves the ownership separation: .github#1605 covers the lru intake-policy decision, while pingora-gateway#13 covers removal of derivative / RUSTSEC-2024-0388.

The sandbox did not compile or execute the Rust tests. Hosted CI must confirm the expected intentional RED result on this exact head.

You are interacting with an AI system.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review the exact current 50b0516a9249c4066e3a0f305dbf2759eae3ae06 four-file child after the hosted RED executed. Scope should remain CHANGELOG.md, TEST_STRATEGY.md, docs/doctoring/TRACEABILITY.md, tests/supply_chain_policy.rs; the intentional failing supplier-intake regression itself is not a request to weaken the gate.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='18fb38b1ba70c4bf222642ef347f3d57a98379a2'
head='50b0516a9249c4066e3a0f305dbf2759eae3ae06'

echo '== Exact topology and effective child scope =='
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf 'merge-base: '; git merge-base "$base" "$head"
printf 'ahead/behind: '; git rev-list --left-right --count "${base}...${head}"
printf 'head parents: '; git show -s --format='%P' "$head"
git diff --name-status "$base" "$head"
git diff --check "$base" "$head"

echo
echo '== Child files end with final newline =='
for path in CHANGELOG.md TEST_STRATEGY.md docs/doctoring/TRACEABILITY.md tests/supply_chain_policy.rs; do
  printf '%s: ' "$path"
  git show "${head}:${path}" |
    python3 -c 'import sys; print("yes" if sys.stdin.buffer.read().endswith(b"\n") else "no")'
done

echo
echo '== Supply-chain test implementation =='
git show "${head}:tests/supply_chain_policy.rs" > /tmp/supply_chain_policy.rs
ast-grep outline /tmp/supply_chain_policy.rs --items all --view expanded || true
cat -n /tmp/supply_chain_policy.rs

echo
echo '== Exact lockfile records =='
git show "${head}:Cargo.lock" > /tmp/Cargo.lock
python3 - <<'PY'
from pathlib import Path
lock = Path("/tmp/Cargo.lock").read_text(encoding="utf-8")
records = []
for block in lock.split("[[package]]")[1:]:
    record = {}
    for raw in block.splitlines():
        line = raw.strip()
        if line.startswith('name = "') and line.endswith('"'):
            record["name"] = line[8:-1]
        elif line.startswith('version = "') and line.endswith('"'):
            record["version"] = line[11:-1]
    records.append(record)
for package in ("derivative", "derivative-like"):
    found = [record for record in records if record.get("name") == package]
    print(f"{package}: count={len(found)}, records={found}")
PY

echo
echo '== Parent compiler/support identity and policy-test controls =='
for path in tests/toolchain_contract.rs Dockerfile Cargo.toml Cargo.lock deny.toml .github/workflows/ci.yml .github/workflows/supply-chain.yml; do
  printf '%s: ' "$path"
  git diff --quiet "$base" "$head" -- "$path" && echo unchanged || echo CHANGED
done
git grep -n -i -E \
  'supply_chain_policy|rustsec_2024_0388_dependency_is_absent_from_committed_lock|#\[ignore|--ignored|--exclude|cfg\s*\(|cargo +test|--locked|RUSTSEC-2024-0388|derivative|ignore\s*=|advisories|cargo +deny|branch\s*=|rev\s*=' \
  "$head" -- Cargo.toml deny.toml .github tests 2>/dev/null || true

echo
echo '== Hosted PR checks and recent relevant workflow runs =='
gh pr view 54 --repo ContextualWisdomLab/pingora-gateway --json headRefOid,statusCheckRollup \
  --jq '{headRefOid, statusCheckRollup: [.statusCheckRollup[] | {name, status, conclusion, detailsUrl}]}'
gh run list --repo ContextualWisdomLab/pingora-gateway --commit "$head" --limit 20 \
  --json databaseId,name,status,conclusion,event,workflowName,url

Length of output: 32204


🏁 Script executed:

#!/bin/bash
set -euo pipefail

run_id='33998449940'
log_file='/tmp/ci-33998449940.log'

gh run view "$run_id" --repo ContextualWisdomLab/pingora-gateway --log-failed > "$log_file"

echo '== Failed-step log: relevant failures =='
rg -n -i -C 5 \
  '(supply_chain_policy|rustsec_2024_0388|derivative|test result:|failures:|error:|panicked|assertion failed|failed,|FAILED)' \
  "$log_file" || true

echo
echo '== Failed jobs and steps =='
gh run view "$run_id" --repo ContextualWisdomLab/pingora-gateway \
  --json jobs \
  --jq '.jobs[] | select(.conclusion == "failure") | {name, conclusion, steps: [.steps[] | select(.conclusion == "failure") | {name, number, conclusion}]}'

Length of output: 23159


@seonghobae No actionable findings.

I reviewed 18fb38b1ba70c4bf222642ef347f3d57a98379a2...50b0516a9249c4066e3a0f305dbf2759eae3ae06 independently.

18fb38b1ba70c4bf222642ef347f3d57a98379a2 is the exact merge base. The range has 75 head-only commits and no base-only commits. The effective child delta contains exactly:

  • CHANGELOG.md
  • TEST_STRATEGY.md
  • docs/doctoring/TRACEABILITY.md
  • tests/supply_chain_policy.rs

git diff --check reports no whitespace errors. Each changed file ends with a final newline.

The child does not duplicate parent compiler or support changes. The endpoint contents are unchanged for tests/toolchain_contract.rs, Dockerfile, Cargo.toml, Cargo.lock, deny.toml, .github/workflows/ci.yml, and .github/workflows/supply-chain.yml.

tests/supply_chain_policy.rs reads the committed lockfile directly with include_str!("../Cargo.lock"). It separates records at [[package]] and compares the full parsed name field to "derivative". The fixture passes and proves that neither dependencies = ["derivative"] nor name = "derivative-like" produces a match.

The test has no scanner-waiver behavior, #[ignore] attribute, or conditional bypass. CI uses cargo test --all-targets --locked. deny.toml retains ignore = []. The Pingora source remains pinned to an immutable Git rev.

Hosted CI run 33998449940 compiled the repository and ran the test targets. The only failing test was:

rustsec_2024_0388_dependency_is_absent_from_committed_lock

Its failure reports the exact committed record:

RUSTSEC-2024-0388 remains in the committed production graph through derivative 2.2.0

The companion exact-match fixture passed. Other discovered tests completed successfully before the intentional failure. Hosted Supply Chain run 33998449901 also succeeded.

Therefore, the hosted RED is the intended independent supplier-intake regression. It is not a compiler, runtime, or fixture failure. The assertion can become GREEN only when the committed lock graph contains no exact derivative package record.

You are interacting with an AI system.

Copy link
Copy Markdown
Contributor Author

Fresh supplier-candidate disposition for this unchanged RED head: the derivative-free Pingora tags 0.3.0, 0.1.1, and 0.1.0 are now statically ruled out as drop-in downgrades for the current gateway request-policy contract, rather than merely lacking compatibility evidence. Current #62 src/pingora_delivery.rs@32e0aeed imports HttpUpstreamRequestPolicy and writes peer.options.http_upstream_request_policy; direct pingora-core/src/upstreams/peer.rs reads at those three tags expose PeerOptions without that current policy field/API. 0.3.0 is additionally reported by GitHub as immutable: false. This does not broaden #54 or change its exact RED: 50b0516a... still fails only because the committed graph contains derivative 2.2.0. Do not replace that causal oracle with a historical downgrade; accepted resolution remains a compatible maintainer-integrated repair (or separately ADR-governed immutable/provenance-bound backport) followed by exact lock regeneration and unchanged regression GREEN.

Copy link
Copy Markdown
Contributor Author

Supplier-state refresh: protected cloudflare/pingora/main has advanced to 4487f7b2ab50f159e4a2cf4f6a6b813f61bb6e19, but the latest published release remains Pingora 0.9.0 and refs/tags/0.9.0 still points to 702f69015e53f7244d6ad2e743de571d859a70a4. Fresh exact 4487f7.../Cargo.toml still declares workspace derivative = "2.2.0"; owner issue #889 remains open. Therefore #54's intended package-absence RED is unchanged. Do not treat moving upstream main as release-qualified repair, and do not clear the gate with an advisory ignore, deleted lock, mutable contributor pin, or downstream fork. Acceptance remains maintainer-integrated removal → release-qualified supplier identity → ordinary gateway pin/lock regeneration → unchanged #54 absence GREEN + #62 semantics revalidation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant