docs: record Pingora parked-read shutdown supplier gap - #47
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughHTTP/1 parked-read graceful shutdown의 Pingora 공급자 격차를 추적 문서에 기록했다. 검증 조건과 릴리스 차단 조건을 제품 기준 및 변경 로그에 반영했다. ChangesPingora 종료 격차 추적
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change documents the parked-read shutdown supplier gap and preserves fail-closed release conditions without changing runtime behavior, dependencies, traffic, or production code. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='239d031237a7fc3c5f5355257412682ca6b94162'
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact changed files ==='
git diff --name-status "$base" "$head"
echo '=== exact diff ==='
git diff --no-ext-diff --unified=80 "$base" "$head"
echo '=== upstream `#844` metadata ==='
gh api repos/cloudflare/pingora/issues/844 --jq '{number,title,state,html_url,labels:[.labels[].name],created_at,updated_at,closed_at,pull_request}'
echo '=== upstream `#969` metadata ==='
gh api repos/cloudflare/pingora/pulls/969 --jq '{number,title,state,html_url,draft,merged,mergeable,merged_at,base:.base.sha,head:.head.sha,updated_at,closed_at}'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
echo '=== Pingora main source at public revision ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/proxy_service.rs?ref=09696b51bc59315353d96686355861604d0bb48c" \
--jq '.content' | base64 -d > "$tmpdir/proxy_service.rs"
rg -n -C 8 'struct HttpProxy|handle_new_request|http_cleanup|shutdown_flag|shutdown\.notified|Notify' "$tmpdir/proxy_service.rs"Length of output: 69775 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='239d031237a7fc3c5f5355257412682ca6b94162'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
echo '=== exact ancestry ==='
printf 'merge-base: '
git merge-base "$base" "$head"
printf 'base tree: '
git rev-parse "${base}^{tree}"
printf 'head parent(s): '
git show -s --format='%P' "$head"
echo '=== supplier commit ==='
gh api "repos/cloudflare/pingora/commits/${supplier}" --jq '{sha,html_url,commit:{message:.commit.message,committer:.commit.committer}}'
echo '=== supplier source ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" --jq '.content' \
| base64 -d > "$tmpdir/lib.rs"
rg -n -C 10 'struct HttpProxy|handle_new_request|http_cleanup|shutdown_flag|shutdown\.notified|notify_waiters|Notify' "$tmpdir/lib.rs"
echo '=== `#844` body and Accepted-label metadata ==='
gh api repos/cloudflare/pingora/issues/844 --jq '{body,labels:[.labels[]|{name,description}]}'
echo '=== `#969` body, changed files, and test-related diff excerpts ==='
gh api repos/cloudflare/pingora/pulls/969 --jq '{body,head:{sha:.head.sha,repo:.head.repo.full_name,ref:.head.ref},base:{sha:.base.sha,ref:.base.ref}}'
gh api repos/cloudflare/pingora/pulls/969/files --paginate --jq '.[] | {filename,status,additions,deletions,patch}' \
> "$tmpdir/pr969-files.json"
cat "$tmpdir/pr969-files.json"
echo '=== `#969` issue comments and reviews ==='
gh api repos/cloudflare/pingora/issues/969/comments --paginate --jq '.[] | {user:.user.login,created_at,body}'
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate --jq '.[] | {user:.user.login,state,submitted_at,body}'Length of output: 38043
I verified exact head The supplier-state statements are accurate. At Pingora The upstream-state statements are accurate. Issue The new traceability note correctly separates:
The contributor-branch rejection rationale is supported by the public PR diff and review. The branch includes the unrelated The RED/GREEN contract does not credit an unmerged supplier fix. It requires repeated race evidence, realistic concurrency profiling, preserved admitted-request drain, and a maintainer-integrated immutable/released capability or governed backport. The release and security gates remain fail-closed. The documentation adds the supplier shutdown dependency without weakening the existing header-control, dependency-policy, exact-head, or traffic-activation gates. ✅ Action performedReview finished.
|
|
@coderabbitai review Please review current exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='6a84e785fceab6b882ff4733d56cf4ec449438fc'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact ancestry ==='
printf 'merge-base: '; git merge-base "$base" "$head"
printf 'head parents: '; git show -s --format='%P' "$head"
echo '=== changed files ==='
git diff --name-status "$base" "$head"
echo '=== exact diff ==='
git diff --no-ext-diff --unified=50 "$base" "$head"
echo '=== changed-document line map ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
nl -ba "$path"
done
echo '=== public upstream `#844` ==='
gh api repos/cloudflare/pingora/issues/844 \
--jq '{number,title,state,html_url,closed_at,labels:[.labels[].name],body}'
echo '=== public upstream `#969` ==='
gh api repos/cloudflare/pingora/pulls/969 \
--jq '{number,title,state,draft,merged,merged_at,mergeable,mergeable_state,html_url,base:{sha:.base.sha},head:{sha:.head.sha,ref:.head.ref,repo:.head.repo.full_name},body}'
echo '=== supplier commit metadata ==='
gh api "repos/cloudflare/pingora/commits/${supplier}" \
--jq '{sha,html_url,commit:{message:.commit.message,committer:.commit.committer}}'
echo '=== supplier shutdown implementation ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
rg -n -C 12 'struct HttpProxy|handle_new_request|http_cleanup|shutdown_flag|shutdown\.notified|notify_waiters|Notify|read_request' "$tmpdir/lib.rs"
echo '=== `#969` changed files and reviews ==='
gh api repos/cloudflare/pingora/pulls/969/files --paginate \
--jq '.[] | {filename,status,additions,deletions,patch}'
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate \
--jq '.[] | {user:.user.login,state,submitted_at,body}'Length of output: 144723 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='6a84e785fceab6b882ff4733d56cf4ec449438fc'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
echo '=== `#46-related` documentation assertions ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
sed -n '=' "$path" | paste -d: - <(cat "$path") \
| grep -E -i -C 2 'pingora|parked|shutdown|notify|`#844`|`#969`|lost-wakeup|lost wakeup|in-flight|immutable|provenance|release' \
|| true
done
echo '=== public issue `#844` ==='
gh api repos/cloudflare/pingora/issues/844 \
--jq '{number,title,state,html_url,closed_at,labels:[.labels[]|{name,description}],body}'
echo '=== public PR `#969` ==='
gh api repos/cloudflare/pingora/pulls/969 \
--jq '{number,title,state,draft,merged,merged_at,mergeable,mergeable_state,html_url,base:{sha:.base.sha},head:{sha:.head.sha,ref:.head.ref,repo:.head.repo.full_name},body}'
echo '=== public supplier source at exact revision ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
grep -n -E -C 12 'struct HttpProxy|handle_new_request|http_cleanup|shutdown_flag|shutdown\.notified|notify_waiters|Notify|read_request' "$tmpdir/lib.rs" || true
echo '=== `#969` patch and review evidence ==='
gh api repos/cloudflare/pingora/pulls/969/files --paginate \
--jq '.[] | {filename,status,patch}'
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate \
--jq '.[] | {user:.user.login,state,submitted_at,body}'Length of output: 46472 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='6a84e785fceab6b882ff4733d56cf4ec449438fc'
echo '=== Notify scope wording in changed documents ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
grep -n -E -i 'process-wide.*(Notify|parked|shutdown)|Notify.*process-wide|one shared.*Notify|single-Notify|single.*Notify|HttpProxy instance' "$path" \
| sed "s|^|${path}:|" \
|| true
done
echo '=== Exact supplier ownership declarations ==='
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
gh api 'repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=09696b51bc59315353d96686355861604d0bb48c' \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
grep -n -E -A10 -B3 'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>' "$tmpdir/lib.rs"Length of output: 12528
I found one documentation accuracy issue.
All other requested checks passed.
You are interacting with an AI system. |
|
@coderabbitai review Please review current exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='d8cb1d9e1e099e3fd830881ad6af1529eb1aa32d'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact ancestry ==='
printf 'merge-base: '; git merge-base "$base" "$head"
printf 'head parents: '; git show -s --format='%P' "$head"
echo '=== changed files ==='
git diff --name-status "$base" "$head"
echo '=== changed file count ==='
git diff --name-only "$base" "$head" | wc -l
echo '=== complete exact diff ==='
git diff --no-ext-diff --unified=30 "$base" "$head"
echo '=== numbered changed documents ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
nl -ba "$path"
done
echo '=== public Pingora issue `#844` ==='
gh api repos/cloudflare/pingora/issues/844 \
--jq '{number,title,state,closed_at,html_url,labels:[.labels[]|{name,description}],body}'
echo '=== public Pingora PR `#969` ==='
gh api repos/cloudflare/pingora/pulls/969 \
--jq '{number,title,state,draft,merged,merged_at,closed_at,mergeable,mergeable_state,html_url,base:{sha:.base.sha},head:{sha:.head.sha,ref:.head.ref,repo:.head.repo.full_name},body}'
echo '=== Pingora supplier commit ==='
gh api "repos/cloudflare/pingora/commits/${supplier}" \
--jq '{sha,html_url,commit:{message:.commit.message,committer:.commit.committer}}'
echo '=== Pingora supplier shutdown implementation ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
rg -n -C 15 'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|handle_new_request|http_cleanup|shutdown\.notified|notify_waiters|read_request' "$tmpdir/lib.rs"
echo '=== public PR `#969` changed files and reviews ==='
gh api repos/cloudflare/pingora/pulls/969/files --paginate \
--jq '.[] | {filename,status,additions,deletions,patch}'
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate \
--jq '.[] | {user:.user.login,state,submitted_at,body}'Length of output: 160048 🏁 Script executed: #!/bin/bash
set -u
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='d8cb1d9e1e099e3fd830881ad6af1529eb1aa32d'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
echo '=== current documents, numbered ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
cat -n "$path"
done
echo '=== focused assertions in every changed document ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
grep -inE -C 2 \
'process-wide|per[- ]`?HttpProxy|HttpProxy instance|shared.*Notify|Notify.*shared|`#844`|`#969`|Accepted|lost.?wakeup|waiter|contention|parked|in-flight|graceful.?drain|RED|GREEN|available_parallelism|worker|immutable|provenance|release.?block|fail.?closed|security' \
"$path" || true
done
echo '=== public Pingora issue `#844` ==='
gh api repos/cloudflare/pingora/issues/844 \
--jq '{number,title,state,closed_at,html_url,labels:[.labels[]|{name,description}],body}' \
|| echo 'ERROR: could not query issue `#844`'
echo '=== public Pingora PR `#969` ==='
gh api repos/cloudflare/pingora/pulls/969 \
--jq '{number,title,state,draft,merged,merged_at,closed_at,mergeable,mergeable_state,html_url,base:{sha:.base.sha},head:{sha:.head.sha,ref:.head.ref,repo:.head.repo.full_name},body}' \
|| echo 'ERROR: could not query PR `#969`'
echo '=== supplier commit metadata ==='
gh api "repos/cloudflare/pingora/commits/${supplier}" \
--jq '{sha,html_url,commit:{message:.commit.message,committer:.commit.committer}}' \
|| echo 'ERROR: could not query supplier commit'
echo '=== supplier HttpProxy shutdown source ==='
if gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"; then
grep -n -E -C 14 \
'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|handle_new_request|http_cleanup|shutdown\.notified|notify_waiters|read_request' \
"$tmpdir/lib.rs" || true
else
echo 'ERROR: could not retrieve supplier source'
fi
echo '=== PR `#969` files and reviews ==='
gh api repos/cloudflare/pingora/pulls/969/files --paginate \
--jq '.[] | {filename,status,additions,deletions,patch}' \
|| echo 'ERROR: could not query PR `#969` files'
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate \
--jq '.[] | {user:.user.login,state,submitted_at,body}' \
|| echo 'ERROR: could not query PR `#969` reviews'Length of output: 202888
I reviewed exact head The previous ownership-scope finding is resolved. The documents now state that the The new ADR correctly remains Proposed. It does not infer Accepted status from a documentation review, internal supplier integration, or public PR The documentation accurately separates these three concerns:
The supplier evidence is represented correctly:
The RED/GREEN criteria remain realistic. RED requires a reproduced survivor with parked new and reused HTTP/1 connections under shutdown jitter. GREEN requires zero survivors under repeated adversarial runs, retained in-flight drain behavior, and realistic high-core worker-topology-aware contention profiling. The documents do not use low-core latency results, reduced worker counts, disabled keep-alive, or a shorter external termination budget as substitute evidence. The release and security gates remain fail-closed. The documentation still requires an immutable maintainer-integrated public capability or a separately governed provenance-bound backport. It preserves exact-head quality, security, supply-chain, OCI, release, rollback, and traffic-activation requirements. You are interacting with an AI system. |
|
@coderabbitai review Please review exact current head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
previous='d8cb1d9e1e099e3fd830881ad6af1529eb1aa32d'
head='007b42f48810edabe3dd87cf9a6249d0a9033423'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git cat-file -e "${base}^{commit}"
git cat-file -e "${previous}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact ancestry ==='
printf 'merge-base(base, head): '; git merge-base "$base" "$head"
printf 'head parents: '; git show -s --format='%P' "$head"
echo '=== full requested-range files ==='
git diff --name-status "$base" "$head"
echo '=== delta since previously reviewed head ==='
git diff --name-status "$previous" "$head"
git diff --no-ext-diff --unified=40 "$previous" "$head"
echo '=== scope wording in requested range ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
rg -n -i -C 3 'process-wide|per[- ]`?HttpProxy|HttpProxy instance|waiter list|parked-read|shared.*Notify|Notify.*shared' "$path" || true
done
echo '=== current OPERABILITY.md ==='
operability="$(fd -a '^OPERABILITY\.md$' . | head -n 1)"
test -n "$operability"
nl -ba "$operability"
echo '=== pinned public Pingora HttpProxy shutdown source ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
rg -n -C 15 'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|handle_new_request|http_cleanup|shutdown\.notified|notify_waiters' "$tmpdir/lib.rs"Length of output: 94107 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='007b42f48810edabe3dd87cf9a6249d0a9033423'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git checkout --quiet "$head"
operability="$(find . -name OPERABILITY.md -type f -print | head -n 1)"
test -n "$operability"
echo '=== OPERABILITY.md scope assertions ==='
grep -inE -C 3 'process-wide|per[- ]`?HttpProxy|HttpProxy instance|waiter list|shared.*Notify|Notify.*shared' "$operability" || true
echo '=== pinned Pingora source: HttpProxy ownership and shutdown use ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
grep -n -E -C 15 \
'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|handle_new_request|shutdown\.notified|http_cleanup|notify_waiters' \
"$tmpdir/lib.rs" || trueLength of output: 15240
I reviewed exact head The merge base is the requested base. The delta after the previously reviewed head changes only The ownership-scope repair is correct. At pinned public Pingora commit
You are interacting with an AI system. |
|
@coderabbitai review Superseding predecessor requests: please review exact current head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
previous='85e9821618019b010eb82a522d058572db42272a'
head='969ffd7db92776c3a2389646e81a39b79705c2e0'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git cat-file -e "${base}^{commit}"
git cat-file -e "${previous}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact ancestry ==='
printf 'merge-base(base, head): '; git merge-base "$base" "$head"
printf 'head parents: '; git show -s --format='%P' "$head"
echo '=== full requested range ==='
git diff --name-status "$base" "$head"
printf 'changed-file count: '; git diff --name-only "$base" "$head" | wc -l
echo '=== delta since predecessor head ==='
git diff --name-status "$previous" "$head"
git diff --no-ext-diff --unified=60 "$previous" "$head"
echo '=== final CHANGELOG.md patch ==='
git diff --no-ext-diff --unified=100 "$base" "$head" -- CHANGELOG.md
echo '=== final product gap baseline patch ==='
git diff --no-ext-diff --unified=100 "$base" "$head" -- docs/product-technical-gap-baseline.md
echo '=== ownership wording in all changed documents at exact head ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
{ line[NR]=$0 }
END {
for (i=1; i<=NR; i++) {
if (line[i] ~ /process-wide|HttpProxy|tokio::sync::Notify|shared waiter|waiter list|parked HTTP\/1|parked-read/) {
s=i-2; if(s<1)s=1
e=i+2; if(e>NR)e=NR
for(j=s;j<=e;j++) printf "%s:%d:%s\n",path,j,line[j]
print "--"
}
}
}'
done
echo '=== all final process-wide uses in the requested range ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
/process-wide/ { printf "%s:%d:%s\n",path,NR,$0 }'
done
echo '=== pinned public Pingora HttpProxy ownership and shutdown implementation ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
rg -n -C 16 \
'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|fn new|handle_new_request|shutdown\.notified|http_cleanup|notify_waiters|read_request' \
"$tmpdir/lib.rs"Length of output: 247355
I reviewed exact head The merge base is the requested base. The range changes ten documentation files. The shutdown- The documents correctly state that each The remaining
They do not expand the shutdown- The final The final You are interacting with an AI system. |
|
@coderabbitai review Please review exact current head Fresh audit found that the latest verifiable CodeRabbit review only covered through |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='969ffd7db92776c3a2389646e81a39b79705c2e0'
supplier='09696b51bc59315353d96686355861604d0bb48c'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
echo '=== exact ancestry and range ==='
printf 'merge-base: '; git merge-base "$base" "$head"
printf 'head parents: '; git show -s --format='%P' "$head"
git diff --name-status "$base" "$head"
printf 'changed files: '; git diff --name-only "$base" "$head" | wc -l
echo '=== exact patches: CHANGELOG and baseline ==='
git diff --no-ext-diff --unified=100 "$base" "$head" -- CHANGELOG.md docs/product-technical-gap-baseline.md
echo '=== focused current-head text in each changed document ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
git show "${head}:${path}" | nl -ba | rg -n -i -C 3 \
'HttpProxy|tokio::sync::Notify|process-wide|waiter|lost.?wakeup|contention|parked|in-flight|graceful.?drain|`#844`|`#969`|Accepted|Proposed|ADR.?0011|immutable|provenance|release.block|security' \
|| true
done
echo '=== public upstream issue `#844` ==='
gh api repos/cloudflare/pingora/issues/844 \
--jq '{number,title,state,closed_at,html_url,labels:[.labels[]|{name,description}],body}'
echo '=== public upstream PR `#969` ==='
gh api repos/cloudflare/pingora/pulls/969 \
--jq '{number,title,state,draft,merged,merged_at,closed_at,mergeable,mergeable_state,html_url,base:{sha:.base.sha},head:{sha:.head.sha,ref:.head.ref,repo:.head.repo.full_name},body}'
echo '=== pinned Pingora supplier source ==='
gh api "repos/cloudflare/pingora/contents/pingora-proxy/src/lib.rs?ref=${supplier}" \
--jq '.content' | base64 -d > "$tmpdir/lib.rs"
rg -n -C 16 \
'pub struct HttpProxy|shutdown: Notify|shutdown_flag: Arc<AtomicBool>|fn new|handle_new_request|shutdown\.notified|http_cleanup|notify_waiters|read_request' \
"$tmpdir/lib.rs"
echo '=== ADR files and headings in requested range ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
case "$path" in
*ADR*|*adr*) echo "--- $path"; git show "${head}:${path}" | nl -ba | sed -n '1,120p' ;;
esac
doneLength of output: 99318 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='969ffd7db92776c3a2389646e81a39b79705c2e0'
echo '=== all ownership-scope uses at exact head ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
{ lines[NR]=$0 }
END {
for (i=1; i<=NR; i++) {
if (lines[i] ~ /process-wide|HttpProxy|tokio::sync::Notify|single-Notify|shared waiter|waiter.list/) {
first=i-2; if (first<1) first=1
last=i+2; if (last>NR) last=NR
for (j=first; j<=last; j++) printf "%s:%d:%s\n", path, j, lines[j]
print "--"
}
}
}'
done
echo '=== lifecycle, correctness, performance, and gate assertions ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
echo "--- $path"
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
{ lines[NR]=$0 }
END {
for (i=1; i<=NR; i++) {
if (lines[i] ~ /lost.?wakeup|contention|parked.read|in.flight|graceful.drain|`#844`|`#969`|Accepted|Proposed|immutable|provenance.bound|admissible.dependency|release.block|fail.closed/) {
first=i-2; if (first<1) first=1
last=i+2; if (last>NR) last=NR
for (j=first; j<=last; j++) printf "%s:%d:%s\n", path, j, lines[j]
print "--"
}
}
}'
done
echo '=== ADR 0011 exact content ==='
git show "${head}:docs/adr/0011-require-released-pingora-shutdown-repair.md" | awk '{printf "%d:%s\n", NR, $0}'
echo '=== shutdown traceability exact content ==='
git show "${head}:docs/doctoring/PINGORA_SHUTDOWN_NOTIFY_TRACEABILITY.md" | awk '{printf "%d:%s\n", NR, $0}'
echo '=== final-delta check after predecessor review target ==='
previous='239d031237a7fc3c5f5355257412682ca6b94162'
git cat-file -e "${previous}^{commit}"
git diff --stat "$previous" "$head"
git diff --no-ext-diff --unified=20 "$previous" "$head" -- CHANGELOG.md docs/product-technical-gap-baseline.mdLength of output: 202571 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='99f7db91e5d693a8ae388dc833fe1c2f296bf404'
head='969ffd7db92776c3a2389646e81a39b79705c2e0'
tmpdir="$(mktemp -d)"
trap 'rm -rf "$tmpdir"' EXIT
echo '=== public PR `#969` changed-file names and audit delta ==='
gh api repos/cloudflare/pingora/pulls/969/files --paginate \
--jq '.[] | {filename,status,additions,deletions,patch}' > "$tmpdir/pr969-files.json"
cat "$tmpdir/pr969-files.json"
echo '=== public PR `#969` reviews ==='
gh api repos/cloudflare/pingora/pulls/969/reviews --paginate \
--jq '.[] | {user:.user.login,state,submitted_at,body}'
echo '=== public PR `#969` review comments ==='
gh api repos/cloudflare/pingora/pulls/969/comments --paginate \
--jq '.[] | {user:.user.login,created_at,path,line,side,body}'
echo '=== contrary lifecycle claims in the ten documents ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
/#969/ && /merged|released|admissible|pinned|dependency|Accepted/ {
printf "%s:%d:%s\n", path, NR, $0
}
/ADR 0011|Status: Accepted|Status: Proposed/ {
printf "%s:%d:%s\n", path, NR, $0
}'
done
echo '=== all remaining process-wide Notify combinations ==='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
git show "${head}:${path}" | awk -v path="$path" '
BEGIN { IGNORECASE=1 }
/process-wide/ && /Notify|shutdown|waiter|parked/ {
printf "%s:%d:%s\n", path, NR, $0
}'
doneLength of output: 33630
I reviewed exact head The shutdown ownership wording is accurate. At Pingora The documents keep the two supplier concerns separate:
The supplier lifecycle wording is accurate:
ADR 0011 correctly remains Proposed. It requires an immutable maintainer-integrated public repair or a separately governed provenance-bound backport. It also requires exact-head RED/GREEN correctness and performance evidence before an Accepted state. The final You are interacting with an AI system. |
seonghobae
added
documentation
ChatGPT Codex Connector
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Exact-current technical sweep on c026e1c8f419c6c5035a36518c3d482dfe7ff8a8..62e8369ba52234229c0b6af817c59d47a5e32bf5 found no new actionable source/documentation/DDD finding after the succession repairs. The range is parent-correct (ahead 38 / behind 0, merge base final #44) and remains documentation-only across ten paths. I specifically rechecked the final-#44 baseline preservation, restored #46 TEST_STRATEGY RED/GREEN contract, per-HttpProxy Notify ownership wording, #20 in-flight-vs-parked-read separation, #43/#45/#40 header-control separation, Proposed ADR 0011, primary-source shutdown traceability, supply-chain immutability boundary, and realistic worker/keep-alive contention requirements. Public Pingora main remains 09696b51bc59315353d96686355861604d0bb48c; #844 is open/Accepted-to-internal and #969 is open/unmerged/dirty, so no mutable supplier branch is credited. This COMMENT is technical evidence only, not an independent APPROVED governance review. Current exact hosted CI/Supply Chain/capacity must still reach terminal success on unchanged 62e8369... before #47 technical closure.
1 participant
Documentation-only successor to final #44. This PR does not implement or close
pingora-gateway#46,cloudflare/pingora#844, orcloudflare/pingora#969.Dependency root
Final #44 is unchanged at
c026e1c8f419c6c5035a36518c3d482dfe7ff8a8. Its exact CI34286468359, Supply Chain34286468411, and PgErd bounded-origin capacity34286468507are terminal GREEN. Capacity artifact10079870584(sha256:c9c578aded6d49cfb23b14f27671dffcdaad94bc55aca94148642e784e7c35b5) is source-bound to that exact head and records 1600 requests, 3200/3200 checks, zero HTTP request failures, aggregate p954.01235475 ms, backend p954.04371395 msover 800 requests, and frontend p953.96607155 msover 800 requests. Those controlled-loopback receipts belong to #44 only and do not transfer to this changed child.Current exact #47 head is
62e8369ba52234229c0b6af817c59d47a5e32bf5. Final #44 is the exact configured base and merge base; compare is ahead 38 / behind 0. The effective diff is ten writer-safe documentation paths only:ARCHITECTURE.md,CHANGELOG.md,OPERABILITY.md,SECURITY.md,TEST_STRATEGY.md,THREAT_MODEL.md,TRD.md, Proposed ADR 0011, focused shutdown traceability, anddocs/product-technical-gap-baseline.md. No force-push, destructive rebase, production Rust, workflow semantics, product auth/business logic, routing, retries, Keyverse, Wardnet, EgressWeave, or consumer source is introduced.Valid supplier finding
Protected public Pingora
main@09696b51bc59315353d96686355861604d0bb48chas eachHttpProxyinstance own one sharedtokio::sync::Notifyfor the HTTP/1 reads handled by that instance while parked waiting for a request. Upstreamcloudflare/pingora#844reports 65.66% combined off-CPU futex wait in the shared waiter path on a 128-core x86 NUMA host and isAcceptedonly into Cloudflare's internal line; that status is not a public immutable release. Public PR #969 remains open/unmerged and currently dirty against public main.Independent #969 review transplanted the lost-wakeup regression to public
09696b51...: the regression fails on main, and an independent 300-round × 8-task jitter harness fails at round 0 on main and passes 300/300 on the PR head. The same review identified non-promotable baggage/uncertainty in the contributor branch: an unrelated audit-policy delta and shard sizing from hostavailable_parallelism()rather than Pingora's configured service-worker topology. The contributor branch is evidence only and is not consumed, pinned, or vendored here.#46 remains a separate Runtime Isolation / graceful-shutdown owner gap. It is distinct from #43/#993 downstream H1 parser byte/count admission, #45/#447 downstream H1 whole-request-header lifetime, #40/#992 upstream response-header lifetime, and #20's already-admitted in-flight SIGTERM drain evidence.
Succession repairs in this head
Fresh parent-current inspection found two valid restack omissions and repaired them instead of closing the child.
First, an intervening #47 baseline rewrite had reintroduced stale pre-repair state after #44 moved: retained slices were again described as
hosted GREEN pending, the obsolete historical #19 package-both-binaries design reappeared, old moving.githubauthority was copied into the durable baseline, and final #44 exact closure disappeared. Intermediate2649f1a2235c2d8c2aefa6ae5f33a886215df173repaired the authority but compressed too much retained baseline history, so it was not treated as final. Follow-up742169f7acd9844762fdedff12a33c464475dd00restored the final #44 baseline and reapplied only the #47 parked-read delta. Final base-to-head baseline patch is limited to 14 additions / 6 deletions and preserves the retained #12→#44 contracts.Second, the parent-correct restack had omitted the historical #47
TEST_STRATEGY.mdacceptance from0b81e275...plus the later per-HttpProxyownership correction from8ac749d8.... Current62e8369...restores that valid delta on the final #44 tree: exact compiled generic and pg-erd RED, many new/reused parked keep-alive connections, adversarial SIGTERM jitter around waiter registration, separate high-concurrency contention characterization, shutdown wall-time/CPU/off-CPU evidence where available, and GREEN only on immutable/released maintainer integration or separately governed provenance-bound backport with zero parked-read survivors and preserved admitted in-flight drain. If a repair shards waiters, acceptance profiles actual configured worker/runtime topology rather than assuming hostavailable_parallelism()equals service workers. Sensitive request/product payload is not needed for this evidence.ADR 0011 remains
Proposed. Shorter grace, fewer workers/connections, disabled keep-alive, callback workarounds, contributor-branch pinning, or copied supplier internals cannot manufacture GREEN.Exact-head technical closure for the documentation projection
Exact
62e8369ba52234229c0b6af817c59d47a5e32bf5now has terminal hosted GREEN across all applicable current-head gates:34293088208:test 102283777519,oci-runtime 102283777692, andload-contract 102283777761all terminal success. The test lane passed exact checkout, Rust 1.98.0 formatting/compile/test, strict lint, warnings-denied rustdoc, pinned coverage tooling, owned-production coverage enforcement, and resolved-lock evidence. OCI rebuilt both admitted images and re-exercised non-root/read-only/capability-free runtime. Load rebuilt the exact gateway/Rust origins and passed generic plus routed pg-erd k6 acceptance.34293088111/candidate-evidence 102283775356: committed dependency audit, both candidate image builds, SPDX dependency SBOM, both image scans, exact-source binding, and evidence upload all terminal success.34293088138: exact Rust 1.98.1 candidate and Rust origins, one-worker serialization self-check, then 16-VU/1600-iteration measurement all terminal success. Artifact10082166631, digestsha256:725e70cb7992b3e3010a95b4aaaac76f0cde98f5cc341500df622ce1a69b174c, records 1600 requests, 3200/3200 checks, zero HTTP request failures, aggregate p952.76302115 ms, backend p952.6450837 ms/ 800, and frontend p952.8390461 ms/ 800. This is controlled-loopback origin-capacity/connection-churn evidence, not production/TLS/WAN SLO credit.5148285805coversc026e1c8...62e8369b, reports no new actionable source/documentation/DDD finding after the two succession repairs, and is anchored to this exact head. There are no inline review threads. It is a technical COMMENT, not an independentAPPROVEDgovernance review.This closes the #47 documentation projection on unchanged exact-head technical evidence. It does not close #46 because the affected public supplier is unchanged and no immutable/released shutdown repair has been consumed. Keep Draft while #46, the supplier release root, and protected promotion remain unresolved.
No protected merge, immutable gateway release, parity, shadow/canary, rollback, cutover, or Nginx/OpenResty removal credit is claimed.