Skip to content

fix(reports): close #851 Vietnamese share and lock RED - #999

Merged
seonghobae merged 8 commits into
feat/leftover-map-compare-plot-explained-share-v2680from
automation/851-vietnamese-lock-repair-20260911
Sep 10, 2026
Merged

fix(reports): close #851 Vietnamese share and lock RED#999
seonghobae merged 8 commits into
feat/leftover-map-compare-plot-explained-share-v2680from
automation/851-vietnamese-lock-repair-20260911

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Repairs the exact #851 f7d1c1741598023eaac199efd0fd605304bb5945 RED without rewriting history.

  • preserves explicit Vietnamese explained-share semantics in the report segment and expanded plot caption;
  • adds a production-bound regression for the comparison graphic segment and fixes the reviewed share/tỷ phần semantic loss;
  • regenerates uv.lock with repository-authoritative uv, moving the editable lineageweave package from 2.65.0 to 2.68.0 rather than hand-editing it;
  • aligns only the three stale Vietnamese i18n.test.ts expectations exposed by the repaired production copy;
  • leaves measurement values and other locales unchanged.

RED→GREEN evidence:

  • 26bf97ab0ba0228cb22253590f1ebd68c66f2c33: production-bound comparison regression. Harness 34528773176 reproduced exactly 1 failing Vietnamese comparison assertion with the two earlier Vietnamese assertions GREEN; minimal source repair then produced lint GREEN and 96/96 focused tests GREEN.
  • Standard PR Tests on predecessor 222e14c2a61db7224b1b575f23cde2c0d648bfa1 exposed exactly 3 stale Vietnamese fixture expectations in i18n.test.ts while the dedicated product regression was GREEN. Harness 34529174433 reproduced 3/252 fixture failures, changed those three expectations only, then produced lint GREEN and 348/348 focused tests GREEN.
  • Harness 34528462950 regenerated uv.lock; uv lock --check passed and logged lineageweave v2.65.0 -> v2.68.0.

All temporary execution workflows self-removed. Net compare against #851 is four product/test/lock files only: frontend/src/i18n.ts, frontend/src/i18n.test.ts, frontend/src/leftoverMapPlotVietnameseCopy.test.ts, and uv.lock.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c1357ac3-95d6-4821-a4a6-a0de9565de1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review: the four-file delta is bounded to Vietnamese explained-share semantics plus repository-generated lock parity. Frontend/full-suite Tests 34529327417 are terminal GREEN on 6198104; no measurement, provider, schema, or canonical-owner authority moves into this repair. This is review evidence only, not self-approval.

@seonghobae
seonghobae merged commit 99f92eb into feat/leftover-map-compare-plot-explained-share-v2680 Sep 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant