fix(reports): close #851 Vietnamese share and lock RED - #999
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review: the four-file delta is bounded to Vietnamese explained-share semantics plus repository-generated lock parity. Frontend/full-suite Tests 34529327417 are terminal GREEN on 6198104; no measurement, provider, schema, or canonical-owner authority moves into this repair. This is review evidence only, not self-approval.
99f92eb
into
feat/leftover-map-compare-plot-explained-share-v2680
Repairs the exact #851
f7d1c1741598023eaac199efd0fd605304bb5945RED without rewriting history.share/tỷ phầnsemantic loss;uv.lockwith repository-authoritativeuv, moving the editablelineageweavepackage from 2.65.0 to 2.68.0 rather than hand-editing it;i18n.test.tsexpectations exposed by the repaired production copy;RED→GREEN evidence:
26bf97ab0ba0228cb22253590f1ebd68c66f2c33: production-bound comparison regression. Harness 34528773176 reproduced exactly 1 failing Vietnamese comparison assertion with the two earlier Vietnamese assertions GREEN; minimal source repair then produced lint GREEN and 96/96 focused tests GREEN.222e14c2a61db7224b1b575f23cde2c0d648bfa1exposed exactly 3 stale Vietnamese fixture expectations ini18n.test.tswhile the dedicated product regression was GREEN. Harness 34529174433 reproduced 3/252 fixture failures, changed those three expectations only, then produced lint GREEN and 348/348 focused tests GREEN.uv.lock;uv lock --checkpassed and loggedlineageweave v2.65.0 -> v2.68.0.All temporary execution workflows self-removed. Net compare against #851 is four product/test/lock files only:
frontend/src/i18n.ts,frontend/src/i18n.test.ts,frontend/src/leftoverMapPlotVietnameseCopy.test.ts, anduv.lock.