Repository navigation
Code retrieval defaults to unlimited context - #1150
Merged
Merged
Conversation
Make token limits an explicit deployment or request choice, including MCP and cursor pages. Keep finite budgets on recomputed cursor pages and document server configuration. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Skip risk annotations when their reservation would leave less than the result-head allowance. Cover finite request and deployment budgets, cursor pages, and the annotation threshold. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
…t' into fix/unlimited-code-token-defaults Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Let callers choose response caps for their repository. Preserve whole retained definitions and selected lessons by default, and fit search history within explicit finite caps. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep tiny explicit context caps within their limit, remove implicit dashboard caps and warm the same ask budget clients use. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Keep retained container navigation when full source is unavailable, and honor finite caps on uses summaries and unavailable context messages. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
Use the symbol output's definition list and keep the map fixture cache private. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
This was referenced Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1111
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Code retrieval returns selected context without an implicit response token cap. Callers and deployments can opt into a cap; result counts and requested body modes still apply.
Why
Repository size and the amount of context a caller needs vary. A fixed response cap can withhold a definition that retrieval already found and force another read. Return the selected context and let callers choose a cap.
Scope and risk
Includes the search default work from #1111, with the history-budget gaps found in fresh review fixed. Search history fits before body budgeting, including missing-pool cursor fallback and no-hit history responses.
The default token budget is unlimited for symbol, enclosing, outline, trace, map, context-pack and review-brief reads. Large symbol definitions return complete retained source instead of automatic skeletons; an explicitly capped container request retains skeleton navigation. If a full container body is unavailable, retained skeletons and outlines remain available. Source completeness checks and bounded source reads still apply.
Ask retrieval, attached file lessons and internal code grounding default to unlimited context. Positive configured caps remain supported. Python SDK defaults, both SDKs' code-query wrappers and dashboard retrieval calls follow the server defaults. Cache warming uses the deployment's ask budget. Generated references and settings history describe the change. Larger responses can consume more client context; no cost, speed or quality improvement is claimed without a measurement.
Compatibility, rollout and rollback
0means unlimited. Search and ask accept omission and use their deployment defaults. Review tiers select sections without adding an implicit token cap.code_search_token_budgetis new and defaults to0;code_ask_token_budget,code_result_lessons_tokens,memory_ask_code_symbol_token_budgetandmemory_ask_code_search_token_budgetandcode_review_brief_rationale_tokensdefault to0. Existing explicit deployment values keep their caps.0or values outside the previous request bounds.Tests
make lint,make typecheck,make format-check: passed.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the changes and checked the static gates. A fresh agent review is required before merge.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist