Repository navigation
Tests follow unlimited retrieval defaults and configured caps - #1151
Merged
Merged
Conversation
Replace stale finite-default and first-row overflow expectations without changing production behavior. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1150
Changelog category (leave one):
Why
Completed unit jobs retain four expectations for finite defaults or for the first rationale row exceeding its cap. The retrieval defaults are unlimited, and explicit rationale caps fit whole rows.
Scope and risk
Tests only. The settings reference expects an unmasked zero default. Cache coverage distinguishes unlimited retrieval from a configured finite default and confirms both keys. Review-brief coverage expects no tier cap on a build or cached read, checks complete selected sections, and covers rationale with a finite cap and with zero.
Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex corrected the assertions from the CI logs and checked static gates. A fresh agent review is required before merge.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist