Skip to content

Tests follow unlimited retrieval defaults and configured caps - #1151

Merged
zlareb1 merged 1 commit into
mainfrom
fix/unlimited-code-default-contracts
Nov 22, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/unlimited-code-default-contracts

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 22, 2026

Copy link
Copy Markdown
Member

Related: #1150

Changelog category (leave one):

  • CI Fix or Improvement

Why

Completed unit jobs retain four expectations for finite defaults or for the first rationale row exceeding its cap. The retrieval defaults are unlimited, and explicit rationale caps fit whole rows.

Scope and risk

Tests only. The settings reference expects an unmasked zero default. Cache coverage distinguishes unlimited retrieval from a configured finite default and confirms both keys. Review-brief coverage expects no tier cap on a build or cached read, checks complete selected sections, and covers rationale with a finite cap and with zero.

Compatibility, rollout and rollback

  • Wire and operator steps: none.
  • No production code, stored data, generated files or runtime defaults change.
  • Rollback restores the stale expectations.

Tests

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex corrected the assertions from the CI logs and checked static gates. A fresh agent review is required before merge.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Static checks pass. Local tests were not run, as requested.
  • No generated files, migrations, hooks or frontend changes.
  • Commits are signed off.

Replace stale finite-default and first-row overflow expectations without changing production behavior.

Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 22, 2026 8:48am UTC

Request Review

@zlareb1
zlareb1 merged commit 8c4a471 into main Nov 22, 2026
49 of 50 checks passed
@zlareb1
zlareb1 deleted the fix/unlimited-code-default-contracts branch November 22, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant