Repository navigation
Declare the namespace authorization for grep lessons - #1132
Merged
Merged
Conversation
Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1128
Changelog category (leave one):
Changelog entry
Declare the existing namespace authorization for code.grep lessons in the scope census.
Why
The scope census rejects the lesson_namespaces input added to code.grep because its authorization function is missing from the declaration map. The handler already checks these namespaces through code_plane_reads.lesson_namespaces before reading lessons.
Scope and risk
One census entry names the existing check, matching the other code lesson readers. No runtime authorization path changes.
Compatibility, rollout and rollback
Tests
Format, lint and type checks pass. The existing scope census is the regression check. Local unit tests were not run at the requester's instruction; CI was not awaited.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex added the declaration and checked the handler and lesson reader.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist