Skip to content

Declare the namespace authorization for grep lessons - #1132

Merged
zlareb1 merged 1 commit into
mainfrom
fix/grep-lessons-scope-declaration
Nov 22, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/grep-lessons-scope-declaration

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 22, 2026

Copy link
Copy Markdown
Member

Related: #1128

Changelog category (leave one):

  • CI Fix or Improvement

Changelog entry

Declare the existing namespace authorization for code.grep lessons in the scope census.

Why

The scope census rejects the lesson_namespaces input added to code.grep because its authorization function is missing from the declaration map. The handler already checks these namespaces through code_plane_reads.lesson_namespaces before reading lessons.

Scope and risk

One census entry names the existing check, matching the other code lesson readers. No runtime authorization path changes.

Compatibility, rollout and rollback

  • Wire and storage: unchanged.
  • Operator steps: none.
  • Rollback: removes the census entry.

Tests

Format, lint and type checks pass. The existing scope census is the regression check. Local unit tests were not run at the requester's instruction; CI was not awaited.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex added the declaration and checked the handler and lesson reader.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Format, lint and type checks pass.
  • Local unit tests remain for CI at the requester's instruction.
  • No generated files, migrations, plugin or frontend changes.
  • Commits are signed off.

Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Building Building Preview Nov 22, 2026 12:41am UTC

Request Review

@zlareb1
zlareb1 merged commit 696d9dd into main Nov 22, 2026
48 of 50 checks passed
@zlareb1
zlareb1 deleted the fix/grep-lessons-scope-declaration branch November 22, 2026 00:43
@zlareb1 zlareb1 mentioned this pull request Nov 22, 2026
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant