Skip to content

Declare grep lesson namespace authorization - #1131

Closed
zlareb1 wants to merge 1 commit into
mainfrom
test/grep-lesson-scope-declaration
Closed

zlareb1 wants to merge 1 commit into
mainfrom
test/grep-lesson-scope-declaration

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Changelog category

  • Bug Fix

Changelog entry

Not required.

Why

The scope-field inventory rejected code.grep.lesson_namespaces because its existing authorization check was not declared. The same assertion failed on the default branch before #1132.

Scope and risk

Adds one inventory entry pointing to server.memory.app.code_plane_reads.lesson_namespaces. Grep already calls that helper through the lesson wrapper, and the helper returns only readable namespaces. No handler, authorization rule, field-discovery pattern or test assertion changes.

Compatibility, rollout and rollback

  • Wire and defaults: none.
  • Operator steps: none.
  • Rollback: removes the inventory entry; runtime behavior is unchanged.

Tests

  • The existing hosted unit assertion fails with the undeclared grep lesson field.
  • Local validation covers the changed file's formatting, lint and syntax, plus unchanged assertions; focused pytest execution is not run locally.
  • Full hosted CI: failed in Postgres 18 isolation. All unit shards and coverage checks passed; the inventory assertion and declared-helper check passed. The integration failure remains unresolved. The same inventory declaration is merged in Declare the namespace authorization for grep lessons #1132, so this pull request is superseded.

AI assistance in the code

  • AI-generated: Codex traced the existing authorization path and added its missing inventory declaration. Independent reviews check the pushed source and public wording.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full hosted formatting, lint, type and unit gates pass.
  • No runtime, schema, SDK, plugin or generated file changes.
  • Existing test assertions and field discovery remain unchanged.
  • Public text contains no private deployment details.
  • Commits are signed off.

Record the readable-namespace check already used by grep lesson enrichment so the scope inventory covers the field.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 22, 2026 12:36am UTC

Request Review

@zlareb1 zlareb1 closed this Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant