Repository navigation
Conversation
Record the readable-namespace check already used by grep lesson enrichment so the scope inventory covers the field. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category
Changelog entry
Not required.
Why
The scope-field inventory rejected
code.grep.lesson_namespacesbecause its existing authorization check was not declared. The same assertion failed on the default branch before #1132.Scope and risk
Adds one inventory entry pointing to
server.memory.app.code_plane_reads.lesson_namespaces. Grep already calls that helper through the lesson wrapper, and the helper returns only readable namespaces. No handler, authorization rule, field-discovery pattern or test assertion changes.Compatibility, rollout and rollback
Tests
AI assistance in the code
AI-generated: Codex traced the existing authorization path and added its missing inventory declaration. Independent reviews check the pushed source and public wording.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist