Skip to content

Bound JSON encoder setup in Cell proof checks - #1041

Open
zlareb1 wants to merge 8 commits into
mainfrom
fix/cell-proof-default-comparison
Open

zlareb1 wants to merge 8 commits into
mainfrom
fix/cell-proof-default-comparison

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Related: #1072
Related: #1077
Related: #1087

Changelog category

  • CI Fix or Improvement

Changelog entry

Not required.

Why

The page proof compares default values on every row. Repeatedly constructing an encoder for individual fields adds work to each comparison. Compare one canonical mapping while retaining exact JSON representations and every default-field refusal.

Scope and risk

The capture helper compares the default fields in one canonical mapping. Regression cases cover every altered default, numeric type distinctions and the number of encoder setups. The page proof, default values and validation rules are retained.

Qualification controls exercise the isolated replicated-erasure lease table already on main, decision-tag filtering for the SCIM query recorder and a private cleanup clock. Missing-lease refusal, unbounded-query negative controls, original cleanup deadlines and original assertions are retained. The existing lease-table fixture remains unchanged.

Workload, pages, resource census, global deadlines, latency and throughput bounds are retained. Latency, throughput and complete acceptance require hosted validation.

Compatibility, rollout and rollback

  • Wire, production server behavior, schema, settings and operator steps: none.
  • Rollback: revert the harness and fixture changes. No persisted server data changes.

Prior-source qualification

Historical command records report 67 passing canonical-comparison, numeric-type refusal, person-query observation and private cleanup controls. Their records name prior heads but do not contain per-run immutable working-source hashes. Committed-file equality does not establish those executed bytes. Their original assertions and deadlines remain unchanged. The earlier Cell latency failure remains a failed acceptance result with an unproven cause; this comparison change does not establish an end-to-end performance fix.

The composition retains current main’s stored review-provenance requirement, 62 memory fields and 44 sparse defaults. The refusal cases cover all 44 defaults, including review provenance. The canonical comparison and cleanup assertions remain; the only additional regression change extends coverage to the new default. Current main supplies the person-query observations and other merged prerequisites. Scoped Ruff, formatting, public prose and committed-range whitespace checks pass. All exact commands and scoped outcomes are retained. No previous review or CI result qualifies this head; a fresh independent entire review and all required full exact-head hosted workflows must pass before merge. No runtime, provider call, performance probe or hosted retry was run.

Tests

This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.

Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical. Committed-source equality is separately verified; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.

AI assistance in the code

  • AI-generated: Codex wrote the changes and controls, then checked bounded encoding and diagnostics, refusal paths, retained assertions and task cleanup.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Acceptance thresholds, workload and deadlines are retained.
  • No production source, generated interfaces, migrations or operator settings change.
  • Commits are signed off.
  • Full exact-head GitHub CI passes.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 11:33am UTC

Request Review

Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 73ef63b)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 0bfc712)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private
clock. A controlled independent clock advance reproduces the elapsed-time
dependency while the original cleanup and refusal assertions stay intact.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 4b03db4)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/cell-proof-default-comparison branch from 49ab94f to 9d57ebb Compare November 21, 2026 00:08
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant