Skip to content

feat: set severity number and event name on the default Logs source #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SpencerTorres wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: set severity number and event name on the default Logs source #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loud-log-fields.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"helm-charts": patch
---

feat: set `severityNumberExpression: "SeverityNumber"` and `eventNameExpression: "EventName"` on the default Logs source (only applies to new installs; existing sources are not modified)
9 changes: 9 additions & 0 deletions charts/clickstack/tests/default-env-vars_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,15 @@ tests:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"kind": "trace",[^}]*"spanLinksValueExpression": "Links"'

- it: should set severity number and event name on the default log source
asserts:
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"kind": "log",[^}]*"severityNumberExpression": "SeverityNumber"'
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"kind": "log",[^}]*"eventNameExpression": "EventName"'

# metricTables keys must match MetricsDataType values; unknown keys
# (e.g. camelCase "exponentialHistogram") are silently dropped by HyperDX.
- it: should register all OTel metric tables on the default metric source
Expand Down
2 changes: 2 additions & 0 deletions charts/clickstack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ hyperdx:
"resourceAttributesExpression": "ResourceAttributes",
"defaultTableSelectExpression": "Timestamp,ServiceName,SeverityText,Body",
"severityTextExpression": "SeverityText",
"severityNumberExpression": "SeverityNumber",
"eventNameExpression": "EventName",
"traceIdExpression": "TraceId",
"spanIdExpression": "SpanId",
"connection": "Local ClickHouse",
Expand Down
Loading