[SpencerTorres]

Closes part of HDX-5772

Point severityNumberExpression at SeverityNumber and eventNameExpression
at EventName, matching HyperDX's own defaults. Only affects new installs.

[changeset-bot]

🦋 Changeset detected

Latest commit: fd2535c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
helm-charts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Deep Review

Scope: 3 files vs base e2c4be5 — charts/clickstack/values.yaml (+2 JSON fields on the default Logs source), charts/clickstack/tests/default-env-vars_test.yaml (+1 helm-unittest test), .changeset/loud-log-fields.md (new patch changeset).
Intent: Point severityNumberExpression at SeverityNumber and eventNameExpression at EventName on the default Logs source, mirroring HyperDX's own defaults. New installs only.

✅ No critical issues found. The change is a clean, well-tested, vendor-consistent config addition. JSON renders validly, the new test anchors correctly on the unique "kind": "log" discriminator and asserts exact values, and it is the direct Logs counterpart to the already-merged Traces schema update.

🟡 P2 — recommended

• charts/clickstack/values.yaml:236 — eventNameExpression points at an EventName column whose existence in the provisioned otel_logs schema cannot be confirmed from this repo; the table is created at runtime by the external clickstack-otel-collector image, so a missing column would surface as a ClickHouse UNKNOWN_IDENTIFIER on new-install log queries rather than at chart-render time.
  • Fix: Confirm the clickstack-otel-collector:2.39.1 ClickHouse logs exporter creates an EventName column in default.otel_logs before merge; SeverityNumber is a standard exporter column and needs no check.
  • _correctness

🔵 P3 nitpicks (1)

• charts/clickstack/tests/default-env-vars_test.yaml:123 — the [^}]* match relies on no brace-bearing nested object being inserted between "kind": "log" and the severity/event fields; a future reordering could make the assert silently stop matching, the same brittleness already accepted in the sibling trace test.
  • Fix: No change needed; noted for awareness, consistent with the established test convention.

---

Reviewers (4): correctness, testing, maintainability, project-standards.

Testing gaps: The helm-unittest only verifies the expression string is present in the rendered DEFAULT_SOURCES env var; it cannot assert the SeverityNumber/EventName columns exist in ClickHouse, so a schema mismatch would still pass CI. This is inherent to chart-level testing and not a blocker.

Note: The single prior PR comment is the automated changeset-bot notification with no substantive feedback, so the previous-comments reviewer was not dispatched.

_{No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR.}