Skip to content

Feature/417 authentication with azure entra id and authentik - #421

Merged
MaartendeKruijf merged 10 commits into
developmentfrom
feature/417-authentication-with-azure-entra-id-and-authentik
Oct 14, 2026
Merged

MaartendeKruijf merged 10 commits into
developmentfrom
feature/417-authentication-with-azure-entra-id-and-authentik

Conversation

@MaartendeKruijf

@MaartendeKruijf MaartendeKruijf commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This PR introduces the new authentication code for SOARCA. It allows for using Entra ID, Authentik and API tokens.

Related issue

Closes 417

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behaviour or API)
  • Documentation
  • Refactor / internal change (no functional change)
  • CI / build / tooling

What changed

The PR changes the authentication library, this does not link it with the active code yet this is done in a followup PR.

How this was tested

Unittests per component a Mock PoC was created to test the various concepts.


Contributor checklist

  • There is at least one issue linked above, and this PR is scoped to it
  • I checked for existing logic first, and reused what was already there instead of duplicating it
  • Branch name uses an allowed prefix: feature/, feature/docs/, bugfix/, release/x.x, or hotfix/
  • PR targets the development branch
  • Branch is rebased on the latest development, with a clean history (no merge commits)
  • make test (unit tests) passes locally
  • make integration-test passes where relevant
  • make lint (golangci-lint) passes with no new issues
  • New or changed logic is covered by tests
  • Code follows the Google Go style guide, with the project's exceptions: receiver names are descriptive (e.g. info, not i), and initialisms are CamelCase (e.g. Xml, not XML)
  • Public API changed → Swagger regenerated (make swagger-docs) and committed
  • User-facing behaviour changed → docs updated (/documentation)
  • Config or environment variables changed → .env.example updated
  • Self-reviewed the diff: no debug code, stray logging, or commented-out blocks
  • I have read and followed the Contribution Guidelines and agree to the Code of Conduct
  • This PR does not disclose a security vulnerability (those go to the maintainers via Slack, not here)

Reviewer checklist

  • No duplication: this doesn't reimplement logic, helpers, or patterns that already exist in the codebase. Where existing code could have solved the issue, it is reused rather than rewritten.
  • The approach is the right one: the problem couldn't have been solved more simply by extending or reusing what's already there.
  • A valid issue is linked and the change matches its scope (no unrelated changes riding along)
  • Branch prefix and target branch (development) are correct
  • CI is green: build, lint, unit tests, and integration tests
  • Changes are covered by tests, and the tests actually exercise the new behaviour (not just present)
  • Code is readable and follows the project's Go style; naming, error handling, and structure fit the codebase
  • No obvious security concerns: input validation, injection, secrets in code/logs, unsafe defaults
  • Public API / Swagger and user-facing docs are updated and accurate where behaviour changed
  • Breaking changes are called out, justified, and acceptable for the current release line
  • Commit history is clean enough to merge (rebased, meaningful messages)
  • I have pulled and run the branch locally where the change warrants it

Notes for reviewers

Comment thread docs/content/en/docs/installation-configuration/_index.md
Comment thread docs/content/en/docs/installation-configuration/_index.md Outdated
@MaartendeKruijf
MaartendeKruijf merged commit a51a536 into development Oct 14, 2026
9 checks passed
@MaartendeKruijf
MaartendeKruijf deleted the feature/417-authentication-with-azure-entra-id-and-authentik branch October 14, 2026 12:24

This branch was successfully deployed

1 active deployment
development-pages — 643d9f36 Deployed Oct 14, 2026 by MaartendeKruijf via deploy-to-pages #962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authentication with Azure Entra ID and Authentik

2 participants