Repository navigation
Pin snakeyaml to 1.32 (CVE-2022-38752, SNYK-JAVA-ORGYAML-3016888) - #394
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…888, sfind-32ca70e4)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-32ca70e4(SNYK-JAVA-ORGYAML-3016888 / CVE-2022-38752, low, CWE-121).UserFrontpulls inorg.yaml:snakeyaml:1.17throughspring-boot-starter-web1.5.4 →spring-boot-starter. Crafted YAML can overflow the stack while parsing, which is a DoS.<properties> <java.version>1.8</java.version> + <snakeyaml.version>1.32</snakeyaml.version> </properties>The Boot 1.5 parent's dependency management reads
snakeyaml.version, so this one line changes only the transitive snakeyaml version.Verification
Snyk before/after issue count: not available. This session's network allowlist (git-manager only) blocks
api.snyk.io, sosnyk test --file=UserFront/pom.xmlfails with a connection error. I requested network access, but it was not granted during the session. After this lands, the scan profile re-run should no longer report SNYK-JAVA-ORGYAML-3016888, and the resolved version should besnakeyaml:1.32.mvn compile/mvn test: could not run. Maven Central is blocked. The 1.5.4 parent and the snakeyaml 1.32 jar are not in~/.m2. The only test (contextLoads) also needs MySQL.Dependency resolution (offline): I ran
maven-dependency-plugin:3.6.1:tree -Dincludes=org.yamlon a copy of this pom with the cached Boot 1.5.8 parent, which manages snakeyaml the same way:org.yaml:snakeyaml:jar:1.17org.yaml:snakeyaml:jar:1.32Runtime harness: Boot 1.5.8
YamlPropertySourceLoaderwith Spring 4.3.12, run on-Xss512kwith a PoC of 100k nested[. snakeyaml 1.33 stands in for 1.32 because 1.32 is not cached; both include the nesting-depth limit added in 1.31/1.32.server.port=8080)StackOverflowError(vulnerable)server.port=8080)YAMLException: Nesting Depth exceeded max 50Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/20b1f5f535b447eab523e5381a29fd5d
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/20b1f5f535b447eab523e5381a29fd5d?variant=devin
Devin Review