Repository navigation
bug: pin snakeyaml 1.33 in UserFront (CVE-2022-38750 / SNYK-JAVA-ORGYAML-3016889) - #443
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…-ORGYAML-3016889)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-d89b07cc(SNYK-JAVA-ORGYAML-3016889, CVE-2022-38750, low, CWE-121).UserFrontgetsorg.yaml:snakeyaml@1.17transitively throughspring-boot-starter-web@1.5.4.RELEASE. In that version a deeply nested YAML document makesBaseConstructor.constructObjectoverflow the stack (DoS).<properties> <java.version>1.8</java.version> + <snakeyaml.version>1.33</snakeyaml.version> </properties>snakeyaml.versionis the property the Boot 1.5.xspring-boot-dependenciesBOM uses to manage snakeyaml. The override changes only that artifact. The Spring Boot parent and the Java version (1.8) stay as they are.Why 1.33 rather than 1.31: 1.31 is the smallest version that clears this one CVE. 1.33 is the smallest version that clears every snakeyaml 1.x finding on this package (CVE-2022-38749/38750/25857 are fixed in 1.31; CVE-2022-38751/38752/41854 are fixed in 1.32/1.32/1.32+). It is also where Snyk's own upgrade path ends up, and it is a minor bump within 1.x, not a major one. Flag: CVE-2022-1471 is not fixed here. It needs snakeyaml 2.x, and that breaks Boot 1.5's
YamlPropertySourceLoader, so it is left out on purpose.Duplicates: these open PRs already pin snakeyaml in
UserFront/pom.xml: #160 and #226 (1.33), #218 and #228 (1.31), #210/#290/#394 (1.32), #171 (2.0). This PR is opened separately because each new finding gets its own PR. Only one of them should land.Verification (offline; Maven Central and api.snyk.io are blocked by the session network policy)
snyk test --file=UserFront/pom.xmlfails withSNYK-CLI-0000because it can't reach api.snyk.io, so there are no before/after issue counts to quote. Please re-run the Snyk scan in CI or the Snyk UI.1.5.4.RELEASEparent isn't cached locally, so I ran this on a copy of the pom with the cached1.5.8.RELEASEparent (samesnakeyaml.versionBOM mechanism), usingmvn -o dependency:tree -Dincludes=org.yaml:spring-boot-starter-web -> spring-boot-starter -> org.yaml:snakeyaml:1.17spring-boot-starter-web -> spring-boot-starter -> org.yaml:snakeyaml:1.33YamlPropertySourceLoader+ Spring 4.3.12,-Xss512k):application.propertiesand has noapplication.yml.mvn testand an app boot. The Boot 1.5.4/1.5.8 thymeleaf/security starters and the MySQL connector aren't in the local Maven cache, and Central is blocked. The only test isUserFrontApplicationTests.contextLoads, and it also needs MySQL.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d5162ac60b44412e821ee3525a039be4
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d5162ac60b44412e821ee3525a039be4?variant=devin
Devin Review