Skip to content

fix(marketplace): give the reachability warning a row it can be read in #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philmerrell wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(marketplace): give the reachability warning a row it can be read in #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions frontend/ai.client/src/app/admin/marketplace/pages/review-queue.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,11 @@ import { parseIso } from '../../../utils/date';
<ul class="flex flex-col gap-3">
@for (row of submissions(); track row.agentId) {
<li
class="flex flex-col gap-3 rounded-2xl border border-gray-200 bg-white p-4 sm:flex-row sm:items-center dark:border-gray-700 dark:bg-gray-800"
class="flex flex-col gap-3 rounded-2xl border border-gray-200 bg-white p-4 dark:border-gray-700 dark:bg-gray-800"
>
<!-- The decision row. The reachability warning is deliberately NOT in
here — see the note on it below. -->
<div class="flex flex-col gap-3 sm:flex-row sm:items-center">
<app-agent-tile [agentId]="row.agentId" [iconUrl]="row.iconUrl" [emoji]="row.emoji" />

<div class="min-w-0 flex-1">
Expand All @@ -99,23 +102,6 @@ import { parseIso } from '../../../utils/date';
{{ row.tagline }}
</p>
}

<!-- Reachability. Never collapsed away and never a blocker: approving a
PRIVATE agent shelves a tile that 404s for everyone but its author,
and that is the one fact the reviewer cannot get from anywhere else
on this row. -->
@if (reachabilityWarning(row); as warning) {
<p
class="mt-1 flex items-start gap-1.5 text-sm/6 text-amber-700 dark:text-amber-400"
>
<ng-icon
name="heroEyeSlash"
class="mt-1 size-4 shrink-0"
aria-hidden="true"
/>
<span>{{ warning }}</span>
</p>
}
</div>

<div class="flex shrink-0 gap-2">
Expand All @@ -138,6 +124,24 @@ import { parseIso } from '../../../utils/date';
Approve
</button>
</div>
</div>

<!-- Reachability, on its own full-width row.
It started inside the identity column, where it was squeezed to ~160px
of a 528px card and wrapped across five lines. A sentence the reviewer
has to work to read is one they will skip, which defeats the point of
surfacing it at all. Never collapsed away and never a blocker:
approving a PRIVATE agent shelves a tile that 404s for everyone but
its author, and that is the one fact this row cannot otherwise tell
them. -->
@if (reachabilityWarning(row); as warning) {
<p
class="flex items-start gap-1.5 border-t border-gray-100 pt-3 text-sm/6 text-amber-700 dark:border-gray-700 dark:text-amber-400"
>
<ng-icon name="heroEyeSlash" class="mt-1 size-4 shrink-0" aria-hidden="true" />
<span>{{ warning }}</span>
</p>
}
</li>
}
</ul>
Expand Down