fix(marketplace): give the reachability warning a row it can be read in - #776
Open
philmerrell wants to merge 1 commit into
Open
fix(marketplace): give the reachability warning a row it can be read in#776philmerrell wants to merge 1 commit into
philmerrell wants to merge 1 commit into
Conversation
Shipped in #773 inside the card's identity column, where it competed for width with the agent name and the two action buttons. Measured on dev: the sentence got **163px of a 528px card and wrapped across five lines**. A warning the reviewer has to work to read is one they will skip, which defeats the entire point of surfacing it — and this is the signal that stands between "approved" and a shelf tile that 404s for everyone but its author. Moved to its own full-width row beneath the decision row, separated by a hairline rule. Same measurement after: **494px, two lines**. Structural only — no wording, no logic, no gating change. Approve stays enabled, and the existing specs (which assert on text, not layout) pass untouched. Verified by applying the same restructure to the live dev DOM before committing, against a real PRIVATE submission in the queue. SPA: 149 files / 1656 tests passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #773, found while verifying it on dev. The warning works — it just doesn't read.
I shipped it inside the card's identity column, where it competes for width with the agent name and the two action buttons. Measured on the live page against a real
PRIVATEsubmission:A warning the reviewer has to work to read is one they will skip — and this is the signal standing between "approved" and a shelf tile that 404s for everyone but its author. Getting it on screen isn't the same as getting it read.
The change
The
<li>was itself the flex row. It now wraps the decision row in its owndiv, and the warning becomes a full-width sibling beneath it, separated by a hairline rule.Structural only: no wording change, no logic change, no gating change. Approve stays enabled.
Verified
Applied the same restructure to the live dev DOM before committing, so the numbers above are measured rather than predicted — the screenshot shows the warning on its own row, two lines, readable.
The existing
review-queue.page.spec.tsassertions pass untouched, which is the point: they assert on text and on Approve staying enabled, not on markup, so a layout change can't silently break them and they can't silently bless a bad layout either. That's why the visual check was done by hand.SPA: 149 files / 1656 tests passed.
Deploy
frontend-deploy.ymlonly.🤖 Generated with Claude Code