Skip to content

fix(desktop): load server language packs for embedded file surfaces - #122

Merged
brkfun merged 1 commit into
BRF-Tech:mainfrom
chengjie:fix/desktop-server-language-packs
Oct 19, 2026
Merged

brkfun merged 1 commit into
BRF-Tech:mainfrom
chengjie:fix/desktop-server-language-packs

Conversation

@chengjie

Copy link
Copy Markdown
Contributor

The desktop file explorer can stay in English/Turkish even when the account uses an installed server language pack. The shell fetches branding through IPC, but never populates the bundled explorer's locale registry, and passes its native-chrome fallback instead of the account language.

Load the active server's language list before mounting, exporting the loader from the same source registry as the bundled explorer. Pass the account language to the explorer and connections panel, including changes between pack languages while native chrome stays English. Accept language tags through the existing settings bridge and server API. Native menus keep their built-in fallback.

Clear the previous server's language list on a server switch and ignore stale branding responses, including after reset. Failures retain built-in fallback. No translations, branding, dependencies or database changes.

Validation (macOS arm64, Node 22 / pnpm 9.12.0 / Go 1.25.14):

  • New desktop regressions fail on the original implementation and pass with the fix; 12 desktop language tests pass.
  • Language registry Vitest suite: 19 pass, including server switches, delayed responses and failure fallback.
  • Full packages, web, sync:embed and backend build passes; check:embed confirms 638 admin and 105 web-component files match.
  • Desktop typecheck and build pass.
  • Full desktop suite: 450 pass, 4 file-watcher timeouts in openwith-outside.test.ts. The same four failures reproduce on pristine v0.57.0; the relevant source/test files are unchanged through this PR base. No assertions relaxed.

Not run: packaged Electron interactive E2E, Windows/Linux installation or full backend tests. The uploaded branch was fetched and its tree verified identical to the locally tested commit.

@chengjie
chengjie force-pushed the fix/desktop-server-language-packs branch from 6ed5eab to 469931b Compare October 19, 2026 02:08
@brkfun
brkfun merged commit 51416e5 into BRF-Tech:main Oct 19, 2026
@brkfun

brkfun commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Thanks a lot, @chengjie! This went out with filex 0.57.2: the desktop app's file list and connections panel now follow the account's language when it comes from a server language pack, and a server switch no longer carries the previous server's languages over.

We built on your loader afterwards: the desktop app now gives up on a server's language list after ten seconds instead of staying on "Connecting", in 0.57.3, which goes out today.

Thank you for this one, and for the careful report in #123. Its fix is in 0.57.3 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants