Repository navigation
fix(desktop): load server language packs for embedded file surfaces - #122
Merged
Merged
Conversation
chengjie
force-pushed
the
fix/desktop-server-language-packs
branch
from
October 19, 2026 02:08
6ed5eab to
469931b
Compare
Contributor
|
Thanks a lot, @chengjie! This went out with filex 0.57.2: the desktop app's file list and connections panel now follow the account's language when it comes from a server language pack, and a server switch no longer carries the previous server's languages over. We built on your loader afterwards: the desktop app now gives up on a server's language list after ten seconds instead of staying on "Connecting", in 0.57.3, which goes out today. Thank you for this one, and for the careful report in #123. Its fix is in 0.57.3 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop file explorer can stay in English/Turkish even when the account uses an installed server language pack. The shell fetches branding through IPC, but never populates the bundled explorer's locale registry, and passes its native-chrome fallback instead of the account language.
Load the active server's language list before mounting, exporting the loader from the same source registry as the bundled explorer. Pass the account language to the explorer and connections panel, including changes between pack languages while native chrome stays English. Accept language tags through the existing settings bridge and server API. Native menus keep their built-in fallback.
Clear the previous server's language list on a server switch and ignore stale branding responses, including after reset. Failures retain built-in fallback. No translations, branding, dependencies or database changes.
Validation (macOS arm64, Node 22 / pnpm 9.12.0 / Go 1.25.14):
Not run: packaged Electron interactive E2E, Windows/Linux installation or full backend tests. The uploaded branch was fetched and its tree verified identical to the locally tested commit.