Repository navigation
fix(net): health-check unmanaged-Site gateways through the tunnel - #931
Closed
Semen Kolesnikov (Lotarcc) wants to merge 5 commits into
Closed
Semen Kolesnikov (Lotarcc) wants to merge 5 commits into
Semen Kolesnikov (Lotarcc) wants to merge 5 commits into
Conversation
Semen Kolesnikov (Lotarcc)
marked this pull request as ready for review
October 15, 2026 19:21
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #926.
Gateways in a Site with
manageCniPlugin: falsehave no pod CIDR, so they have no overlay addressand
registerPeersWithHealthCheckskipped them. Their BPF entries were never health-checked orfailed over. Probing the gateway's internal IP over the underlay is not an option: firewalls
between Sites typically allow only the encapsulation (GENEVE), not the health-check port, so the
gateway would be marked down.
These gateways are now probed at their internal IPv4 address out of
unbounded0:healthcheck.Manager.AddPeerViasets the outgoing interface per packet (IP_PKTINFO), so theprobe leaves through
unbounded0without a kernel route and replies still reach the sharedsocket. The interface index is cached and refreshed after a failed send.
localCidrskeep it out, asa single nexthop, so probes keep flowing while the gateway is down and it can recover.
without a route, so IPv6-only gateways are still not probed.
Lab (kind, unmanaged Calico Site with an Internal gateway pool, remote managed Site over GENEVE,
UDP 9997 dropped on every node's underlay):
Not changed:
ReconcileresetsHealthy=trueon every reconcile, so a Down state only drainsuntil the next reconcile. That applies to all gateways today.
Testing:
TestManagerProbesViaInterface,TestSessionWriteViaUnknownInterface,TestAddPeerViaKeepsSessionWhenUnchanged,TestAddPeerViaReplacesSessionWhenInterfaceChanges,TestGatewayHealthTarget,TestGatewayProbePins,TestRegisterUnmanagedGatewayHealthCheck;go test ./internal/net/healthcheck/ ./cmd/unbounded-net-node/ ./internal/net/controller/onLinux;
make lint; lab scenario above.