Repository navigation
fix(net): health-check unmanaged-Site gateways through the tunnel - #990
Open
Semen Kolesnikov (Lotarcc) wants to merge 1 commit into
Open
Semen Kolesnikov (Lotarcc) wants to merge 1 commit into
Semen Kolesnikov (Lotarcc) wants to merge 1 commit into
Conversation
Contributor
Author
|
@microsoft-github-policy-service terminate |
Contributor
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #926, for the health-check note in its review. Since #926, remote nodes program
gateways in a Site with
manageCniPlugin: falseeven without a pod CIDR, butregisterPeersWithHealthCheckstill skips them because they have no overlay address. They are neverhealth-checked or failed over. This replaces #931, rebased on main after #943.
Probing the gateway's internal IP over the underlay is not an option: firewalls between Sites
typically allow only the encapsulation (GENEVE), not the health-check port, so the gateway would be
marked down.
These gateways are now probed at their internal IPv4 address out of
unbounded0:healthcheck.Manager.AddPeerViasets the outgoing interface per packet (IP_PKTINFO), so theprobe leaves through
unbounded0without a kernel route and replies still reach the sharedsocket. The interface index is cached and refreshed after a failed send.
localCidrskeep it out, asa single nexthop, so probes keep flowing while the gateway is down and it can recover.
without a route, so IPv6-only gateways are still not probed.
It also corrects the #926 comments that said such a gateway never gets a podCIDR: an explicit
assignmentEnabled: truecan still assign one, and the gateway is then probed at its overlayaddress as before.
Lab (kind, unmanaged Calico Site with an Internal gateway pool, remote managed Site over GENEVE, main
at ae6dfab, UDP 9997 dropped on every node's underlay):
Remote <-> gateway and remote -> member pod traffic is unchanged. Lab runs disable the #964
neighbor tuner, which kind's network namespace does not support.
Not changed: nodes inside the unmanaged Site have no overlay address either, so they still do not
health-check their own gateways.
Part of #921.
Testing:
TestManagerProbesViaInterface,TestSessionWriteViaUnknownInterface,TestAddPeerViaKeepsSessionWhenUnchanged,TestAddPeerViaReplacesSessionWhenInterfaceChanges,TestGatewayHealthTarget,TestGatewayProbePins,TestRegisterUnmanagedGatewayHealthCheck;go test ./cmd/unbounded-net-node/ ./internal/net/healthcheck/ ./internal/net/netlink/on Linux;golangci-lint on the changed packages; lab scenario above.