Skip to content

fix(package): resolve edition-suffixed Inno Setup output name #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Sep 8, 2026
+10 −1
Merged

fix(package): resolve edition-suffixed Inno Setup output name #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion scripts/package/package-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,16 @@ function build_setup() {
else
env AW_VERSION=$version_no_prefix "$innosetupdir/iscc.exe" scripts/package/activitywatch-setup.iss
fi
mv dist/activitywatch-setup.exe dist/$filename
# The Research Edition patcher rewrites OutputBaseFilename in the .iss
# (activitywatch-research[-tauri]-setup), so resolve the produced file
# instead of hardcoding the standard name. dist/ is fresh at this point,
# so exactly one setup exe must exist.
setup_src=(dist/activitywatch*-setup.exe)
if [ ${#setup_src[@]} -ne 1 ] || [ ! -f "${setup_src[0]}" ]; then
echo "ERROR: expected exactly one dist/activitywatch*-setup.exe, got: ${setup_src[*]}"
exit 1
fi
mv "${setup_src[0]}" "dist/$filename"
echo "Setup built!"
}

Expand Down