fix(package): resolve edition-suffixed Inno Setup output name - #1436
Conversation
The Research Edition patcher (#1434) rewrites OutputBaseFilename in both .iss files to activitywatch-research[-tauri]-setup, but package-all.sh still moved the hardcoded standard name — failing both Windows jobs on the v0.14.0b5-research tag build (mv: cannot stat). Glob the single produced setup exe instead, failing loudly if the count is ever not 1.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThis PR fixes Windows packaging for edition-suffixed Inno Setup outputs.
Confidence Score: 5/5The PR appears safe to merge and correctly handles standard and edition-suffixed Windows installer outputs. The packaging flow guarantees a fresh output directory, produces one installer, and now explicitly rejects missing or ambiguous matches before renaming the artifact. Important Files Changed
Reviews (1): Last reviewed commit: "fix(package): resolve edition-suffixed I..." | Re-trigger Greptile |
The v0.14.0b5-research tag build (run 34208437212) failed on exactly the two Windows jobs: #1434's research patcher renames the Inno Setup
OutputBaseFilenametoactivitywatch-research-setup/activitywatch-research-tauri-setup(which worked — the log shows the compiled exe), butpackage-all.shstill ranmv dist/activitywatch-setup.exe …→mv: cannot stat→make packageError 1 on both Qt and Tauri. All non-Windows jobs passed.Fix: glob the single produced
dist/activitywatch*-setup.exe(dist/ is fresh at this point) with a fail-loud assertion that exactly one exists, then move it to the final$filename. Works for both editions and stays correct if the patcher's naming evolves.Escaped the 6.2 research PR-CI leg because that job doesn't exercise Windows packaging — noting that as a follow-up candidate rather than expanding this PR.