Repository navigation
fix: support Windows CA bundle for timestamp verification #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,19 @@ folder `release/simple-run/`. The terms (segment, boundary, chain entry, anchor) | |
| ## 1. Consistency check, without a GPU | ||
|
|
||
| Needs Python 3.12 or newer, `git`, `openssl`, `sha256sum` and network access. On macOS, | ||
| `sha256sum` comes with `brew install coreutils` (as `gsha256sum`). Download `release/simple-run/` | ||
| `sha256sum` comes with `brew install coreutils` (as `gsha256sum`). | ||
|
|
||
| ### Windows | ||
|
|
||
| On Windows, install Python 3.12 or newer, Git for Windows, and ensure OpenSSL is available. The verifier uses the `certifi` CA bundle when the platform does not provide one of the standard system CA-bundle paths. | ||
|
|
||
| From PowerShell, download `release/simple-run/` and run the same verification command shown below. If OpenSSL is installed with Git for Windows but is not on `PATH`, add the Git OpenSSL directory to `PATH` for the current PowerShell session: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Provide PowerShell commands for the Windows flow. Line 27 directs PowerShell users to run the Bash block below. That block uses the POSIX assignment Either instruct users to run the block in Git Bash, or provide PowerShell syntax: $env:OVL_DEVICE = "cpu"
python ovl-code/simple/ovl.py verify --run . --weights conversation-model.ptAs per path instructions, commands in
|
||
|
|
||
| ```powershell | ||
| $env:Path = "C:\Program Files\Git\mingw64\bin;$env:Path" | ||
| ``` | ||
|
|
||
| The normal verification process checks the DigiCert and FreeTSA timestamps. Do not use `--no-timestamps` unless you intentionally want to skip timestamp verification. Download `release/simple-run/` | ||
| without the `ckpt-*.pt` files, then from that folder: | ||
|
|
||
| ```bash | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the macOS hash command runnable.
This line states that Homebrew provides
gsha256sum, but the verification block still invokessha256sum. The documented macOS flow therefore fails unless the user adds a GNU coreutils path or alias. Usegsha256sumon macOS, or document the requiredPATHchange.As per path instructions, commands in
**/*.mdfiles must be runnable as written.Source: Path instructions