Repository navigation
ci: run the checks on release branches too - #44
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Add Carrot credits or activate Agent usage billing to use Autofix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI only ran for
main. A pull request into a release branch therefore mergedwith no checks at all — which is how a red test reached
release/4.1.2without anything objecting.
The Linux CI job then failed on
mainfor a test that could never pass:test_api_key_file_requires_owner_only_modeasserted the error messagecontains
0600, but the message has always named the remediation commandinstead (
chmod 600). The test is POSIX-only and the release machine isWindows, so it was skipped everywhere it was authored and only ran for the
first time on Ubuntu.
The production message was right and is unchanged; the assertion now checks
the two things the message actually says.
What this PR changes
.github/workflows/ci.yml— CI now runs on pushes torelease/**and onpull requests targeting
release/**, not justmain.cloudmesh/tests/test_api_hardening.py— the corrected assertion.Why the release branch needs CI
The release branch is where the release is prepared, and it is merged into
mainbefore the tag is cut. A branch that is only ever checked by CI afterit has already been merged cannot stop anything: the failure arrives on
mainas a surprise, with the release already cut.With this change, a pull request into
release/4.1.2runs the same twelvejobs a pull request into
maindoes.Evidence
mainafter the assertion fix: CI run 39574023330 — all twelve jobsgreen, including
Test (ubuntu-latest, Python 3.12), the job thatfailed.
1 failed, 1098 passed, 6 skippedon
Test (ubuntu-latest, Python 3.12).