Skip to content

ci: run the checks on release branches too - #44

Merged
ALI88708 merged 1 commit into
mainfrom
fix/ci-for-release-branches
Oct 21, 2026
Merged

ALI88708 merged 1 commit into
mainfrom
fix/ci-for-release-branches

Conversation

@ALI88708

Copy link
Copy Markdown
Owner

Why

CI only ran for main. A pull request into a release branch therefore merged
with no checks at all — which is how a red test reached release/4.1.2
without anything objecting.

The Linux CI job then failed on main for a test that could never pass:
test_api_key_file_requires_owner_only_mode asserted the error message
contains 0600, but the message has always named the remediation command
instead (chmod 600). The test is POSIX-only and the release machine is
Windows, so it was skipped everywhere it was authored and only ran for the
first time on Ubuntu.

The production message was right and is unchanged; the assertion now checks
the two things the message actually says.

What this PR changes

  • .github/workflows/ci.yml — CI now runs on pushes to release/** and on
    pull requests targeting release/**, not just main.
  • cloudmesh/tests/test_api_hardening.py — the corrected assertion.

Why the release branch needs CI

The release branch is where the release is prepared, and it is merged into
main before the tag is cut. A branch that is only ever checked by CI after
it has already been merged cannot stop anything: the failure arrives on
main as a surprise, with the release already cut.

With this change, a pull request into release/4.1.2 runs the same twelve
jobs a pull request into main does.

Evidence

  • main after the assertion fix: CI run 39574023330 — all twelve jobs
    green, including Test (ubuntu-latest, Python 3.12), the job that
    failed.
  • Before the fix: CI run 39543609222 — 1 failed, 1098 passed, 6 skipped
    on Test (ubuntu-latest, Python 3.12).

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b2c112c-70a6-423b-8d9a-f38d7234937b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

@ALI88708
ALI88708 merged commit 935e180 into main Oct 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant