Repository navigation
Match Flatpak app identities and repair dock reconnects - #9
Open
gabrielbaez wants to merge 1 commit into
Open
gabrielbaez wants to merge 1 commit into
gabrielbaez wants to merge 1 commit into
Conversation
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, and why
Flatpak applications selected from the installed-app list can keep playing on the default channel because the saved desktop ID (for example,
com.spotify.Clientorcom.microsoft.Edge) differs from the stream's name or executable. Read the portal identity from the PipeWire client, including information arriving after playback starts, and retain executable/name aliases for existing assignments.Use those aliases consistently for assignment removal, playing status, picker deduplication, and focused-app matching. Removing a legacy alias or its channel preserves any remaining canonical assignment. OpenDeck's “In front” action can still match
msedgewhen the host window PID cannot be related to the sandbox stream PID.When a dock disappears, some PipeWire versions leave its loopback modules alive. Queue device removals and retire affected loopbacks on the engine tick, then restore them when the device returns. This also handles a replacement appearing under the same name before the next tick.
Checked
cargo fmt --all,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepass (180 unit tests).cargo run -p pipedeck-engine --example smokepasses all 98 checks against an isolated PipeWire 1.4.11 server, including client-only Flatpak identity, focus aliases, both alias-release orders, dock absence, and rapid same-name replugging.This branch starts directly from upstream
main(6864b2f). It is independent of the master-control UI changes in #10; the two branches merge without conflicts.