Repository navigation
Add synchronized channel and mix master controls - #10
Open
gabrielbaez wants to merge 1 commit into
Open
gabrielbaez wants to merge 1 commit into
gabrielbaez wants to merge 1 commit into
Conversation
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, and why
OpenDeck can change channel or mix master volume while the mixer grid continues to show only the independent per-cell faders. Add master sliders and mute buttons to the channel cards and mix headers so those changes are visible and adjustable directly in Pipedeck. Master controls stay outside the settings/reorder buttons, and engine notifications update them without echoing commands back.
Muted speakers now use a red muted icon throughout the mixer and settings. Physical input rows also get working master gain and mute: compose the master into each connected cell after processing, preserve each cell's saved gain/mute, and leave the capture device's hardware controls unchanged. Show the same master controls in input-channel settings and account for their gain in the meters.
Checked
cargo fmt --all,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepass (172 unit tests).Full-smoke baseline comparison: on isolated PipeWire 1.4.11, this branch passes 92 checks and hits the existing dock-disconnect cleanup failure fixed by #9. All eight new input-master checks pass. On host PipeWire 1.6.11, this branch and untouched upstream
6864b2freproduce the same three failures: dock cleanup and two ZamAutoSat plug-in checks. No new smoke failures were introduced.This branch starts directly from upstream
main(6864b2f) and builds independently of #9. The two branches merge without conflicts. Merging #9 first is preferable for the existing dock-recovery test.