📝 docs(general): 提交语音日程提醒工具产品原型设计文档 - #55
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
P1 — Execute only a trusted copy of the bot when secrets are present. On pull_request runs, the default checkout is the PR merge ref, so the later step executes .github/scripts/deepseek-github-bot.mjs from contributor-controlled head code while exposing DEEPSEEK_API_KEY (and a write-capable GITHUB_TOKEN). A same-repository contributor who cannot read Actions secrets can modify this script in a PR and transmit the secret when the workflow runs. Checkout the script from the trusted default branch (or otherwise isolate trusted bot code) before passing secrets.
| const text = [ | ||
| payload.comment?.body, | ||
| payload.review?.body, | ||
| payload.issue?.body, |
There was a problem hiding this comment.
P2 — Restrict mention matching to the current event text. For comment/review events this also searches the persistent issue/PR title and body. Once a description contains /ai, /bot, or another configured phrase, every later unrelated comment or review will keep triggering the bot, so mention mode effectively becomes automatic for that thread. Select the text by event type: use the new comment/review body for discussion events and the title/body only for issue/PR opened or edited events.
|
|
||
| async function getRecentComments(owner, repo, issueNumber, token) { | ||
| const limit = positiveInt(env.DEEPSEEK_BOT_RECENT_COMMENTS, 8); | ||
| const path = `/repos/${owner}/${repo}/issues/${issueNumber}/comments?per_page=${limit}`; |
There was a problem hiding this comment.
P2 — Fetch the newest comments rather than the first page. per_page=${limit} only limits the first page returned by the issue-comments endpoint; it does not select the tail of the discussion. Once a thread has more than the configured limit, recentComments contains the oldest comments and omits the current discussion, which can make the generated guidance stale. Paginate to the last page (or fetch then take the final limit entries).
cdcf261 to
47e06b8
Compare
ZhaoXingPeng
changed the title
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
| ```text | ||
| 用户：删掉今天下午三点和 Alex 的会。 | ||
|
|
||
| 系统语音：已删除今天下午三点和 Alex 的会。删错了就说撤销。 |
There was a problem hiding this comment.
P1 — Require confirmation before deleting even a uniquely matched event. The risk table at line 115 and acceptance criterion 14 require deletion to be confirmed before execution, but this flow deletes immediately after the user's first request. Please add a confirmation step and keep the event unchanged until the user confirms.
|
|
||
| 用户：确定。 | ||
|
|
||
| 系统语音：已取消明天下午三点和 Alex 的会，可以撤销。 |
There was a problem hiding this comment.
P2 — Add the required IM receipt and undo details to destructive/transformative flows. The acceptance criterion at line 535 says modification, skip, pause, termination, and deletion each need a matching IM receipt and undo explanation, but this single-event skip flow only provides voice feedback; the pause/termination flows have the same omission. Without the receipt/action state, the documented IM contract cannot be implemented or verified consistently.
规范化复核记录（2026-08-26）本条评论不替代原 PR 描述，只补充工程过程索引。
后续变更请回到 Issue 驱动的 PR；已关闭/已合并对象保留为历史记录，不在此处覆盖事实。 |
ZhaoXingPeng
changed the title
2 participants
这份 PR 提交语音日程提醒工具的产品原型设计文档，用于评审 #54 是否可以作为后续原型和 Demo 的基线。本次已按最近三个 Proposal 修正：P1 负责语音创建与查询，P2 只处理提醒关闭和稍后，P3 负责已有日程变更与周期控制。
请重点确认：P1/P2/P3 的边界是否一致，语音与 IM 的分工是否清楚，创建冲突、并发提醒、周期范围、删除和撤销这些高风险场景是否足够支撑 MVP。
Refs #54
Lifecycle: Draft；产品原型评审用，不使用 Fixes 自动关闭 Issue。
本次提交
资料查找2.0/语音日程提醒工具-产品原型设计文档.md本次不做
验证
git diff origin/main...HEAD --check通过风险与收口
zhaoxingpeng/deepseek-github-bot；但标题、正文、Issue [Product] 语音日程提醒工具产品原型设计文档提案-20260721 #54 和最终 diff 已改为原型设计语义。AI 协助说明
AI 协助读取 #56/#57/#58 最近 Proposal 活动，整理原型修正点并检查文档结构、PR 文件列表和去 AI 味结果；产品取舍和最终评审决定由团队人工负责。
规范化索引（2026-08-26）
一句话结论：本 PR 的原始改动描述保持不变；以下区块统一记录关联、Review、CI/测试和后续动作，便于按工程审查要求复核。
关联 Issue
变更与生命周期
Review 与 CI
AI 使用与责任
后续动作
保留为历史交付记录；后续改动新建 Issue/PR。
本记录参考 2026-08-26 工程审查关注项：PR/人工 Review、Milestone/Issue 讨论、CI 与测试质量、AI 使用边界。