Fixes asynchronous LINQ methods not being converted to their synchronous counterparts#123
Merged
Merged
Conversation
… respective synchronous ones
virzak
approved these changes
Jun 26, 2026
Contributor
|
Wow, this one was a tough one to get right! Thanks for fixing the fix of my initial fix. 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a small regression causing
IAsyncEnumerableLINQ methods belonging to theAsyncEnumerableclass to be left as is rather than being transformed to the respectiveIEnumerableLINQ methods of theEnumerableclass. This happened because of a change intended to avoid conversion ofEntityFrameworkQueryableExtensionsmethods toSystem.Linq.Queryablewhen a compatible "Asyncless" method was already present among the EF Core extensions.This ended up also affecting the
IAsyncEnumerableextensions, which for the most part lack the "Async" suffix so they were already deamed compatible and their transformation was skipped.The fix consists in adding a condition that forces conversion when the containing type happens to be
AsyncEnumerable.fixes #118