Align rehearsal helper with shared beacon minimum - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #27 lowered the explicitly non-production rehearsal beacon floor from 60 to 12 seconds so Relay can retain real future Quicknet rounds in fast PR checks. The standalone
mpc-rehearsal-confighelper test and flag help still hardcoded 60, causing the otherwise-passinggo test ./...job to fail.Use
mpcrehearsal.MinimumBeaconLeadSecondsin both places so the helper cannot drift from its validator again.Validation:
go test ./scripts/mpc-rehearsal-config ./internal/mpcrehearsal ./cmd/mpc-ceremony -count=1go vet ./scripts/mpc-rehearsal-config ./internal/mpcrehearsal ./cmd/mpc-ceremonygit diff --check