Skip to content

fix walker deinit - #3330

Merged
techatrix merged 3 commits into
zigtools:masterfrom
henrispriet:fix-walker-deinit
Nov 15, 2026
Merged

techatrix merged 3 commits into
zigtools:masterfrom
henrispriet:fix-walker-deinit

Conversation

@henrispriet

@henrispriet henrispriet commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

@neoto

neoto commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Closes #3332

This will also need a bump in the minimum Zig version because there's no backwards compatibility

@henrispriet

henrispriet commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Do i change it to 1) the latest nightly build or 2) the minimal build that includes commit 8473df81b3718f009ee2e8c8cfe18bec2494912b? If 2, how do i find which release that is? 😅

I'll do 1 for now, so that this PR can be merged if that's ok, and otherwise let me know how to do 2.

@neoto

neoto commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

1 should do it AFAIK, but I'd honestly leave that to the maintainers since there's other things that usually go along with it, like the Nix stuff...

@techatrix

Copy link
Copy Markdown
Member

I personally go for the second strategy by using something like zig-overlay's sources.json. But that is not a requirement and using latest nightly build is totally fine. Since I have check that min zig version is correct and possibly handle a nix flake update as well, you might as well just leave all of this to me.

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/ac588ef1c914865dad517b337ea0eb9694a4021c?narHash=sha256-XuAV2cUwaod3Bt4XFVqiXz3v1w2ex16W6Sv4S7EWres%3D' (2026-11-08)
  → 'github:NixOS/nixpkgs/f1e5c356f35d07e7b71a6b5e6c9338e0b029e0c0?narHash=sha256-qXFIqA6FCcx7XeDzw0ZNlkDT9UiCzrNDwK8RuU8RcHM%3D' (2026-11-13)
• Updated input 'zig-flake':
    'github:silversquirl/zig-flake/a16d0a105ba8f33a35b04ef67194e35784022a66?narHash=sha256-ge/Hg9mrl90G8qBWrX0XjV1t0XVRduCg8vT63KVJEPo%3D' (2026-11-11)
  → 'github:silversquirl/zig-flake/0f9ee5cdd5b8400b0b1786ae1f34bc8562259762?narHash=sha256-UbPnat%2B/OQ4X490UWZK0iGsg4pJUWj5xSNymmMiKH/g%3D' (2026-11-15)
@techatrix
techatrix merged commit 0edb306 into zigtools:master Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants