Repository navigation
feat(tui): show when a newer kite release exists - #15
Merged
Merged
Conversation
The --iceberg-quantity help text changed in 2d8143d but the generated reference still showed the old text.
Each instance opens its own ticker connection and runs its own pollers, and instances do not share local state. Say so, and point at the ticker connection cap and poll_secs.
TUI users only learned about a release by running kite upgrade --check or kite doctor. The TUI now checks GitHub in the background at startup and, when a newer release exists, shows update vX.Y.Z in the header and a toast naming the command to run. The lookup is the one upgrade --check already makes. Its result is cached in ~/.cache/kite/update.json for a day so several windows share one request, and the toast fires once per release. A failed lookup is silent. Installs under a Nix store or Homebrew Cellar path are told to use their package manager. "update_check": false in tui.json or KITE_NO_UPDATE_CHECK=1 turns it off.
From review: a failed lookup hid a newer release the cache already knew about, a cache dated in the future stayed fresh, an unwritable cache toasted on every launch, and the package-manager hint missed symlinked installs that kite upgrade refuses. The hint now asks kite upgrade's own install check, and the tests clean up their temp directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TUI users only find out about a new
kiterelease if they runkite upgrade --checkorkite doctor. The TUI now tells them.What changed
upgrade --checkmakes. When it's newer than the running binary, the header status line showsupdate vX.Y.Zin the warning colour, and a toast names the command to run. Startup and sign-in never wait for the lookup, and nothing upgrades on its own.~/.cache/kite/update.jsonfor 24 hours, so several open windows share one request. The toast fires once per release, and later sessions show only the header item. A failed lookup shows nothing and is not cached.kite upgrade."update_check": falseintui.json, orKITE_NO_UPDATE_CHECK=1.CLI_REFERENCE.md, which missed the--iceberg-quantityhelp change in 2d8143d. The other adds a "Running more than one window" note to the TUI guide covering the ticker connection cap, per-window polling and unshared local state.Reviewer notes
Verification
just lintandcargo test --workspacepass locally (with a realTERM; three theme tests fail underTERM=dumbonmaintoo).Not checked by hand: the notice on screen in a live TUI session.