judges-action#1160: add nil size for yegor256/nil-size-repo to Fbe#repository

[Yegorov]

Need for zerocracy/judges-action#1160

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of repository size values for edge cases.

• Tests

  • Added test coverage for empty repository and nil size scenarios.

[coderabbitai]

Walkthrough

The Fbe::FakeOctokit#repository method is refactored to use a case statement for computing repository size, mapping specific repository names to custom sizes: 'yegor256/empty-repo' yields 0, 'yegor256/nil-size-repo' yields nil, and others yield 470. Two new test methods validate this behavior.

Changes

Cohort / File(s)	Summary
Core Logic Refactoring lib/fbe/octo.rb	Refactored repository(name) method to replace inline conditional with case statement for size computation, adding explicit handling for 'yegor256/nil-size-repo' → nil and 'yegor256/empty-repo' → 0.
Test Coverage test/fbe/test_octo.rb	Added test_fetches_fake_empty_repo and test_fetches_fake_nil_size_repo test methods to validate the new size-mapping behavior for empty and nil-size repositories.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• The refactoring follows a straightforward pattern with clear mappings and no complex logic
• Test additions follow existing conventions
• Changes are localized to a single method and its test coverage

Possibly related PRs

• judges-action#852: fix Fbe::FakeOctokit#repository #260: Related refactoring of the same Fbe::FakeOctokit#repository method, also converting inline conditionals to case statements but for different return fields (full_name vs. size).

Poem

🐰 A case for each repo, neat and bright—
Empty ones return zero's light,
Nil-size ones handled just so,
Tests ensure we always know!
Rabbit hops through the code with glee! 🌙

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "add nil size for yegor256/nil-size-repo to Fbe#repository" accurately describes a primary change in the changeset. The PR modifies the repository size computation logic to handle the yegor256/nil-size-repo case by returning nil, adds a corresponding test case, and refactors the size assignment to use a case statement. The title is specific, clear, and directly related to the main objective referenced in the PR description (judges-action#1160), allowing reviewers to understand the intent without ambiguity.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a0c0a9 and 13cf3ee.

📒 Files selected for processing (2)

• lib/fbe/octo.rb (2 hunks)
• test/fbe/test_octo.rb (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

test/fbe/test_octo.rb (1)

lib/fbe/octo.rb (3)

• octo (44-232)
• o (288-290)
• repository (613-659)

🔇 Additional comments (2)

lib/fbe/octo.rb (1)

618-623: LGTM! Clean refactoring with case statement.

The refactoring from an inline conditional to a case statement improves readability and maintainability. The new mapping for 'yegor256/nil-size-repo' correctly returns nil, which is appropriate for testing scenarios where repository size data is absent.

Also applies to: 637-637

test/fbe/test_octo.rb (1)

340-350: LGTM! Well-structured test coverage.

The two new test methods properly validate the special-case repository size mappings. The use of .then with a block is clean and idiomatic, and the assertions correctly verify both the zero-size and nil-size scenarios.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Yegorov]

@yegor256 merge this PR, please.

[yegor256]

@Yegorov why this may happen? It looks like a bug in GitHub API.

[Yegorov]

@yegor256 Yes, it looks like a bug, but it could also be something with the token's access rights.

[yegor256]

@Yegorov maybe we should fix the root cause: access rights problem. This change looks like a simulation of something that never happens in reality.

[Yegorov]

@yegor256 Unfortunately, I can't help here, as I don't have the full context of the situation.
Can you make a request to view information about the repository with this token?

[edmoffo]

The diff matches the stated intent of judges-action#1160 and the two new tests cover both the empty-repo and nil-size-repo branches. CI is green.

The thread on line 621 about fixing the root cause versus extending the test fake is still open; deferring to that discussion before merge.

[bibonix]

The change adds two synthetic repository names to the test fake (yegor256/empty-repo keeps size 0; yegor256/nil-size-repo returns nil). It matches what the consumer in judges-action#1160 needs to exercise its nil-handling branch, and the two added tests pin both branches. CI is green.

The thread on line 621 raises a real question about whether the fake should simulate behavior the real API never produces; that decision sits with the maintainers and is the reason this is a COMMENT verdict rather than an approval. The branch is also currently in a conflicting state against master and needs a rebase before merge.