Skip to content

chore: update pre-commit hook sp-repo-review #836

Open
DimitriPapadopoulos wants to merge 3 commits intozarr-developers:mainfrom
DimitriPapadopoulos:sp-repo-review
Open

chore: update pre-commit hook sp-repo-review #836
DimitriPapadopoulos wants to merge 3 commits intozarr-developers:mainfrom
DimitriPapadopoulos:sp-repo-review

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Apr 12, 2026

updates:

  • github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04

https://learn.scientific-python.org/development/guides/gha-wheels/#publishing

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

updates:
- github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04
  PyProject:
  └── PP304 Sets the log level in pytest ❌
      log_level should be set. This will allow logs to be displayed on failures.
  GitHub Actions:
  └── GH105 Use Trusted Publishing instead of token-based publishing on PyPI ❌
@DimitriPapadopoulos DimitriPapadopoulos changed the title Sp repo review chore: update pre-commit hook sp-repo-review Apr 12, 2026
@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

I am not sure how to test the changes for the GH105 rule.

@d-v-b
Copy link
Copy Markdown
Contributor

d-v-b commented Apr 12, 2026

we definitely do not want to merge any changes to our publishing workflow without tests in place. For example, a workflow that pushes to testpypi. I do not have access to testpypi for the zarr-developers organization -- it was claimed by @jakirkham, and he does not respond to any communication attempts. I opened a ticket to deal but so far no response from the pypi admins.

Short-term we should probably make a zarr-developers-test-pypi org on testpypi and use it while we wait for @jakirkham or the pypi admins to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants