chore: update pre-commit hook sp-repo-review #836
Open
DimitriPapadopoulos wants to merge 3 commits intozarr-developers:mainfrom
Open
chore: update pre-commit hook sp-repo-review #836DimitriPapadopoulos wants to merge 3 commits intozarr-developers:mainfrom
DimitriPapadopoulos wants to merge 3 commits intozarr-developers:mainfrom
Conversation
updates: - github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04
PyProject:
└── PP304 Sets the log level in pytest ❌
log_level should be set. This will allow logs to be displayed on failures.
GitHub Actions: └── GH105 Use Trusted Publishing instead of token-based publishing on PyPI ❌
eb1c950 to
52b797b
Compare
Contributor
Author
|
I am not sure how to test the changes for the |
Contributor
|
we definitely do not want to merge any changes to our publishing workflow without tests in place. For example, a workflow that pushes to testpypi. I do not have access to testpypi for the zarr-developers organization -- it was claimed by @jakirkham, and he does not respond to any communication attempts. I opened a ticket to deal but so far no response from the pypi admins. Short-term we should probably make a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates:
https://learn.scientific-python.org/development/guides/gha-wheels/#publishing
TODO: